[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125655: Xembed SNI Proxy
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-10-30 15:54:44
Message-ID: 20151030155444.14097.81429 () mimi ! kde ! org
[Download RAW message or body]
--===============9177224376572719600==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 3:54 p.m.)
Review request for Plasma.
Repository: plasma-workspace
Description
-------
The goal of this project is to make xembed system trays available in Plasma.
This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] available in \
Plasma which only supports StatusNotifierItem [2].
Ideally we also want this to work in an xwayland session, making X system tray icons available \
even when plasmashell only has a wayland connection.
How it works (in theory)
* We register a window as a system tray container
* We render embeded windows composited offscreen
* We render contents into an image and send this over DBus via the SNI protocol
* XDamage events trigger a repaint
* Activate and context menu events are replyed via X send event into the embedded container as \
left and right clicks
Code is a mix of hacks and bodges bashing client apps into place, and I happily acknowledge it \
looks pretty bad. Unfotunately most of it seems to be needed, but I'd love to be proved wrong \
on most of it.
---
CMakeLists changes are obviously currently wrong, I can strip half of find_packages and I need \
an add_subdirectory in the root file, but it's easier for me to sync with the separate repo \
mirror this way till we're close to merging. I expect this to take quite some revisions.
Diffs (updated)
-----
xembed-sni-proxy/xembedsniproxy.desktop PRE-CREATION
xembed-sni-proxy/xcbutils.h PRE-CREATION
xembed-sni-proxy/sniproxy.cpp PRE-CREATION
xembed-sni-proxy/snidbus.cpp PRE-CREATION
xembed-sni-proxy/sniproxy.h PRE-CREATION
xembed-sni-proxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION
xembed-sni-proxy/snidbus.h PRE-CREATION
xembed-sni-proxy/org.kde.StatusNotifierItem.xml PRE-CREATION
xembed-sni-proxy/main.cpp PRE-CREATION
xembed-sni-proxy/fdoselectionmanager.cpp PRE-CREATION
xembed-sni-proxy/fdoselectionmanager.h PRE-CREATION
CMakeLists.txt 50091ea8ffb01177d34e18217b929cfb9ede3d23
xembed-sni-proxy/CMakeLists.txt PRE-CREATION
xembed-sni-proxy/Readme.md PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/125655/diff/
Testing
-------
Thanks,
David Edmundson
--===============9177224376572719600==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125655/">https://git.reviewboard.kde.org/r/125655/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2015, 3:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The goal of \
this project is to make xembed system trays available in Plasma.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is to \
allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] available in Plasma which \
only supports StatusNotifierItem [2].</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Ideally we also want this to work in an xwayland \
session, making X system tray icons available even when plasmashell only has a wayland \
connection.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">How it works (in theory)</p> <ul style="padding: \
0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">We register a window as a system tray container</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">We render \
embeded windows composited offscreen</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">We render contents into an image and send this \
over DBus via the SNI protocol</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">XDamage events trigger a repaint</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Activate and context menu events are replyed via X send event into the embedded \
container as left and right clicks</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Code is a mix of hacks and bodges bashing client apps into place, and I happily \
acknowledge it looks pretty bad. Unfotunately most of it seems to be needed, but I'd love to be \
proved wrong on most of it.</p> <hr style="text-rendering: inherit;margin: 0;padding: \
0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" /> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">CMakeLists \
changes are obviously currently wrong, I can strip half of find_packages and I need an \
add_subdirectory in the root file, but it's easier for me to sync with the separate repo mirror \
this way till we're close to merging. I expect this to take quite some revisions.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>xembed-sni-proxy/xembedsniproxy.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>xembed-sni-proxy/xcbutils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembed-sni-proxy/sniproxy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembed-sni-proxy/snidbus.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembed-sni-proxy/sniproxy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembed-sni-proxy/org.kde.StatusNotifierWatcher.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>xembed-sni-proxy/snidbus.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembed-sni-proxy/org.kde.StatusNotifierItem.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>xembed-sni-proxy/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembed-sni-proxy/fdoselectionmanager.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>xembed-sni-proxy/fdoselectionmanager.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: \
grey">(50091ea8ffb01177d34e18217b929cfb9ede3d23)</span></li>
<li>xembed-sni-proxy/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembed-sni-proxy/Readme.md <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125655/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9177224376572719600==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic