'Re: Review Request 125873: preliminar support for task geometries in wayland'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125873: preliminar support for task geometries in wayland
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-10-30 13:43:23
Message-ID: 20151030134323.14097.41003 () mimi ! kde ! org
[Download RAW message or body]

--===============2613696482844274529==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125873/
-----------------------------------------------------------

(Updated Oct. 30, 2015, 1:43 p.m.)

Review request for kwin and Plasma.

Repository: kwin

Description
-------

make the minimize effect work by reading taskGeometry from plasmawindowmanagement and \
returning as iconGeometry().

It still supports a single taskbar as on x11. the architecture will have to change \
somehow to allow to know from where panel we want to minimize (or if not secified \
searching for the nearest panel) suggestions welcome :)

Diffs (updated)
-----

  shell_client.cpp b466f97 
  shell_client.h fee22c4 
  abstract_client.h 128c141 
  main_wayland.cpp 5dc7e9f 

Diff: https://git.reviewboard.kde.org/r/125873/diff/

Testing
-------

Thanks,

Marco Martin

--===============2613696482844274529==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125873/">https://git.reviewboard.kde.org/r/125873/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Oct. 30, 2015, 1:43 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make the minimize effect work by reading taskGeometry \
from plasmawindowmanagement and returning as iconGeometry().</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
still supports a single taskbar as on x11. the architecture will have to change \
somehow to allow to know from where panel we want to minimize (or if not secified \
searching for the nearest panel) suggestions welcome :)</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>shell_client.cpp <span style="color: grey">(b466f97)</span></li>

 <li>shell_client.h <span style="color: grey">(fee22c4)</span></li>

 <li>abstract_client.h <span style="color: grey">(128c141)</span></li>

 <li>main_wayland.cpp <span style="color: grey">(5dc7e9f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125873/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2613696482844274529==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 