[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125864: Add back the Agenda part of the Calendar
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-10-29 16:59:22
Message-ID: 20151029165922.14097.78034 () mimi ! kde ! org
[Download RAW message or body]
--===============3816724690396189417==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Oct. 29, 2015, 5:55 p.m., Sebastian Kügler wrote:
> > applets/digital-clock/package/contents/ui/CalendarView.qml, line 99
> > <https://git.reviewboard.kde.org/r/125864/diff/1/?file=413259#file413259line99>
> >
> > if (updatedData === monthView.currentDate) ?
> >
> > I don't know if js date comparisons work that well, but seems simpler and \
> > clearer...
No, this wouldn't work, there was a lengthy discussion yesterday in #plasma about \
this. A summary:
<ChALkeR> But that compares references.
<ChALkeR> {} == {} ? false
...javascript.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125864/#review87678
-----------------------------------------------------------
On Oct. 29, 2015, 5:24 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125864/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 5:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Adds back the Agenda that was there pre-5.0 with some changes.
>
> It now shows an overview of the given day events/holidays. I'd
> like to add a second view at some point that would show you the
> selected day by hours but that is much more work and the freeze
> is getting closer, so maybe that will have to wait till 5.6.
>
>
> Diffs
> -----
>
> applets/digital-clock/package/contents/ui/CalendarView.qml b52eb10
>
> Diff: https://git.reviewboard.kde.org/r/125864/diff/
>
>
> Testing
> -------
>
> Selecting a day correctly changes the date in the agenda and correctly displays the \
> events of the day.
> Event removal/modification also removes/modifies it from the agenda.
>
>
> File Attachments
> ----------------
>
> Current look in Breeze
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/5485250c-8d20-409e-8a5b-0eda7a9d7b8d__snapshot29.png
> Multiple same-day events
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d453a01e-f9cf-4da3-8f6a-fac5aa6aadf5__snapshot18.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============3816724690396189417==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125864/">https://git.reviewboard.kde.org/r/125864/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 29th, 2015, 5:55 p.m. CET, <b>Sebastian \
Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125864/diff/1/?file=413259#file413259line99" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/digital-clock/package/contents/ui/CalendarView.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">92</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="nx">updatedDate</span> \
<span class="o">-</span> <span class="nx">monthView</span><span \
class="p">.</span><span class="nx">currentDate</span> <span class="o">===</span> \
<span class="mi">0</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if \
(updatedData === monthView.currentDate) ?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't know if js date \
comparisons work that well, but seems simpler and clearer...</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, this \
wouldn't work, there was a lengthy discussion yesterday in #plasma about this. A \
summary:
<ChALkeR> But that compares references.
<ChALkeR> {} == {} ? false
...javascript.</pre>
<br />
<p>- Martin</p>
<br />
<p>On October 29th, 2015, 5:24 p.m. CET, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2015, 5:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Adds back the Agenda that was there pre-5.0 with some \
changes.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It now shows an overview of the given day \
events/holidays. I'd like to add a second view at some point that would show you the
selected day by hours but that is much more work and the freeze
is getting closer, so maybe that will have to wait till 5.6.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Selecting a day correctly changes the date in the \
agenda and correctly displays the events of the day.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Event \
removal/modification also removes/modifies it from the agenda.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/ui/CalendarView.qml <span style="color: \
grey">(b52eb10)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125864/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/5485250c-8d20-409e-8a5b-0eda7a9d7b8d__snapshot29.png">Current \
look in Breeze</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d453a01e-f9cf-4da3-8f6a-fac5aa6aadf5__snapshot18.png">Multiple \
same-day events</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3816724690396189417==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic