'Re: Review Request 125858: Fix SystemLoadViewer freezing plasmashell'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125858: Fix SystemLoadViewer freezing plasmashell
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-10-29 12:22:28
Message-ID: 20151029122228.14097.13926 () mimi ! kde ! org
[Download RAW message or body]

--===============7085992771125680292==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125858/#review87663
-----------------------------------------------------------

can you push into branch Plamsa/5.4 too

- David Edmundson

On Oct. 29, 2015, 12:18 p.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125858/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 12:18 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Yrjölä.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> The SystemLoadViewer freezes plasmashell when the systemmonitor data-engine returns \
> erroneous values. The freeze only happens with the compact bars selected. 
> This patch ensures that the proportions of the loads do not exceed 1.
> 
> This patch should fix BUG: 348385
> 
> 
> Diffs
> -----
> 
> applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 8023b44 
> 
> Diff: https://git.reviewboard.kde.org/r/125858/diff/
> 
> 
> Testing
> -------
> 
> I did run a version of this patch over night that had extra debug printouts and I \
> got 17 printouts with huge values returned. The limitation of the value to max 1, \
> prevented freezes. 
> 
> Thanks,
> 
> Kåre Särs
> 
> 

--===============7085992771125680292==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125858/">https://git.reviewboard.kde.org/r/125858/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">can \
you push into branch Plamsa/5.4 too</p></pre>  <br />

<p>- David Edmundson</p>

<br />
<p>On October 29th, 2015, 12:18 p.m. UTC, Kåre Särs wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, David Edmundson and Martin Yrjölä.</div>
<div>By Kåre Särs.</div>

<p style="color: grey;"><i>Updated Oct. 29, 2015, 12:18 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The SystemLoadViewer freezes plasmashell when the \
systemmonitor data-engine returns erroneous values. The freeze only happens with the \
compact bars selected.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This patch ensures that the proportions \
of the loads do not exceed 1.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch should fix \
BUG: 348385</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I did run a version of this patch over night that had \
extra debug printouts and I got 17 printouts with huge values returned. The \
limitation of the value to max 1, prevented freezes.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span \
style="color: grey">(8023b44)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125858/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7085992771125680292==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 