[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125743: Keep aspect ratio in default KSplash background
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-10-28 16:00:44
Message-ID: 20151028160044.14097.24966 () mimi ! kde ! org
[Download RAW message or body]
--===============6859605987234393805==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 21, 2015, 11:05 p.m., David Edmundson wrote:
> > Makes sense for the default behaviours to match
>
> Martin Klapetek wrote:
> Match what? Do we have similar code elsewhere? Btw Hrvoje reported that this is \
> less than ideal as it "letterboxes" the background, which I was a bit worried \
> about.
> So, I'm thinking about Image.PreserveAspectCrop rather.
>
> David Edmundson wrote:
> match imagewallpaper default
Ah, but image wallpaper uses image package, so it has much more resolutions to choose \
from (the default anyway). This has a single one, so I think we should ship 16:10 \
ratio background and just center-crop it.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125743/#review87228
-----------------------------------------------------------
On Oct. 21, 2015, 8:51 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125743/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 8:51 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> I'm just not sure if it's better to do Fit or Crop. I went with Fit as that simply \
> fits the whole artwork, but let me know if you think differently.
> Ideally this should use a wallpaper package for the background, but I don't know \
> how to use it from QML (if possible at all).
> Issues with Fit:
> * If the image is different aspect ratio than the screen, it would add black \
> borders either above/below or left/right
> Issues with Crop:
> * if the image has bigger resolution than the screen, it will get cropped to be the \
> screen resolution, so eg. the distro ships 1920x1200 wallpaper and on 1024x768 the \
> crop would be quite big (the image would still be centered so cropped on the sides) \
>
> Diffs
> -----
>
> lookandfeel/contents/splash/Splash.qml fdeb1ea
>
> Diff: https://git.reviewboard.kde.org/r/125743/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============6859605987234393805==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125743/">https://git.reviewboard.kde.org/r/125743/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 21st, 2015, 11:05 p.m. CEST, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Makes sense for the default behaviours to \
match</p></pre> </blockquote>
<p>On October 28th, 2015, 4:48 p.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Match \
what? Do we have similar code elsewhere? Btw Hrvoje reported that this is less than \
ideal as it "letterboxes" the background, which I was a bit worried about.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">So, I'm thinking about Image.PreserveAspectCrop rather.</p></pre> \
</blockquote>
<p>On October 28th, 2015, 4:51 p.m. CET, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">match \
imagewallpaper default</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, \
but image wallpaper uses image package, so it has much more resolutions to choose \
from (the default anyway). This has a single one, so I think we should ship 16:10 \
ratio background and just center-crop it.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On October 21st, 2015, 8:51 p.m. CEST, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Oct. 21, 2015, 8:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm just not sure if it's better to do Fit or Crop. I \
went with Fit as that simply fits the whole artwork, but let me know if you think \
differently.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ideally this should use a wallpaper package for the \
background, but I don't know how to use it from QML (if possible at all).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Issues with Fit:
* If the image is different aspect ratio than the screen, it would add black borders \
either above/below or left/right</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Issues \
with Crop:
* if the image has bigger resolution than the screen, it will get cropped to be the \
screen resolution, so eg. the distro ships 1920x1200 wallpaper and on 1024x768 the \
crop would be quite big (the image would still be centered so cropped on the \
sides)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/splash/Splash.qml <span style="color: \
grey">(fdeb1ea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125743/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6859605987234393805==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic