[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125839: Quicklaunch: Show default icon when launcher icon is empty
From: "David Rosca" <nowrep () gmail ! com>
Date: 2015-10-28 13:08:43
Message-ID: 20151028130843.14097.6377 () mimi ! kde ! org
[Download RAW message or body]
--===============1037582348535184247==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 28, 2015, 12:24 p.m., David Edmundson wrote:
> > applets/quicklaunch/package/contents/ui/IconItem.qml, line 35
> > <https://git.reviewboard.kde.org/r/125839/diff/1/?file=413122#file413122line35>
> >
> > sexy QML tip for future
> >
> > you can also write this as
> >
> > iconName: launcher.iconName || "fork"
> >
> > it's a tiny bit faster to execute and once we start getting used to this syntax \
> > it's easier to read.
Thanks, I'll remember it :)
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125839/#review87574
-----------------------------------------------------------
On Oct. 28, 2015, 1:08 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125839/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 1:08 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> Always show icon, even when launcher icon is empty.
>
>
> Diffs
> -----
>
> applets/quicklaunch/package/contents/ui/IconItem.qml 0e449f7
>
> Diff: https://git.reviewboard.kde.org/r/125839/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Rosca
>
>
--===============1037582348535184247==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125839/">https://git.reviewboard.kde.org/r/125839/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 28th, 2015, 12:24 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125839/diff/1/?file=413122#file413122line35" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/quicklaunch/package/contents/ui/IconItem.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">35</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="nx">string</span> <span class="k">iconName \
:</span> <span class="nx">launcher</span><span class="p">.</span><span \
class="nx">iconName</span> <span class="o">==</span> <span \
class="s2">""</span> <span class="o">?</span> <span \
class="s2">"fork"</span> <span class="o">:</span> <span \
class="nx">launcher</span><span class="p">.</span><span \
class="nx">iconName</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">sexy \
QML tip for future</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">you can also write this as</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">iconName: launcher.iconName || "fork"</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it's \
a tiny bit faster to execute and once we start getting used to this syntax it's \
easier to read.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks, I'll remember it :)</p></pre> <br />
<p>- David</p>
<br />
<p>On October 28th, 2015, 1:08 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2015, 1:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Always show icon, even when launcher icon is \
empty.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/quicklaunch/package/contents/ui/IconItem.qml <span style="color: \
grey">(0e449f7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125839/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1037582348535184247==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic