'Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard cras'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard cras
From:       "Christoph Feck" <cfeck () kde ! org>
Date:       2015-10-21 21:56:10
Message-ID: 20151021215610.14267.41564 () mimi ! kde ! org
[Download RAW message or body]

--===============4504059086459563840==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125416/#review87231
-----------------------------------------------------------

Raphael, does the crash still happen with Plasma 5.4.2? There is a comment at bug \
328807 mentioning a related bug 260869 about modality, which got fixed for Plasma \
5.4.2.

- Christoph Feck

On Oct. 9, 2015, 3:43 p.m., Raphael Kugelmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125416/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 3:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 328807
> https://bugs.kde.org/show_bug.cgi?id=328807
> 
> 
> Repository: ksysguard
> 
> 
> Description
> -------
> 
> BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" \
> (affected SensorType: DancingBars) 
> https://bugs.kde.org/show_bug.cgi?id=328807
> 
> Two issues fixed:
> - crash during removing a bar Sensor
> - wrong Sensors is removed
> - labels are not set as expected after removing a bar
> 
> 
> Diffs
> -----
> 
> gui/SensorDisplayLib/BarGraph.cpp ecd6674ea4f66c3c061feb31c6a68e2e7abed885 
> gui/SensorDisplayLib/DancingBars.cpp 13c8a45f4f4ca9dd16f62cdf6295bcd6643d2a12 
> gui/SensorDisplayLib/DancingBarsSettings.h 27df0666db53621ecddb2e4763b26509103f7381 \
>  gui/SensorDisplayLib/DancingBarsSettings.cpp \
> 6eb9c21b1670b028570e3826620b98e07eac266d  
> Diff: https://git.reviewboard.kde.org/r/125416/diff/
> 
> 
> Testing
> -------
> 
> Tested
> - no crash anymore
> - the remaining sensors are the one as expected
> 
> 
> Thanks,
> 
> Raphael Kugelmann
> 
> 

--===============4504059086459563840==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125416/">https://git.reviewboard.kde.org/r/125416/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Raphael, does the crash \
still happen with Plasma 5.4.2? There is a comment at bug 328807 mentioning a related \
bug 260869 about modality, which got fixed for Plasma 5.4.2.</pre>  <br />

<p>- Christoph Feck</p>

<br />
<p>On October 9th, 2015, 3:43 p.m. UTC, Raphael Kugelmann wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Raphael Kugelmann.</div>

<p style="color: grey;"><i>Updated Oct. 9, 2015, 3:43 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=328807">328807</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ksysguard
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BugFix for "Bug 328807 - Removing sensor from graph \
causes KSysGuard crash" (affected SensorType: DancingBars)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">https://bugs.kde.org/show_bug.cgi?id=328807</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Two \
                issues fixed:
- crash during removing a bar Sensor
- wrong Sensors is removed
- labels are not set as expected after removing a bar</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">Tested
- no crash anymore
- the remaining sensors are the one as expected</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>gui/SensorDisplayLib/BarGraph.cpp <span style="color: \
grey">(ecd6674ea4f66c3c061feb31c6a68e2e7abed885)</span></li>

 <li>gui/SensorDisplayLib/DancingBars.cpp <span style="color: \
grey">(13c8a45f4f4ca9dd16f62cdf6295bcd6643d2a12)</span></li>

 <li>gui/SensorDisplayLib/DancingBarsSettings.h <span style="color: \
grey">(27df0666db53621ecddb2e4763b26509103f7381)</span></li>

 <li>gui/SensorDisplayLib/DancingBarsSettings.cpp <span style="color: \
grey">(6eb9c21b1670b028570e3826620b98e07eac266d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125416/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4504059086459563840==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 