[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125655: Xembed SNI Proxy
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-10-16 13:20:07
Message-ID: 20151016132007.1403.49674 () mimi ! kde ! org
[Download RAW message or body]
--===============7194707772017689439==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote:
> > xembedsniproxy/sniproxy.h, lines 42-50
> > <https://git.reviewboard.kde.org/r/125655/diff/1/?file=411303#file411303line42>
> >
> > hmm?
>
> David Edmundson wrote:
> ah right, I need some advice on here.
>
> There are properties that exist in the SNI spec that I can't do anything with.
> Should I return blank values, or return DBus errors?
>
> Currently I do the latter.
> Our plasma dataengine handles that fine, but I'm not sure which is more \
> semantically correct.
maybe dbus errors are more likely to crap out on other implementations? (no idea how \
to test this on unity)
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86912
-----------------------------------------------------------
On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2015, 11:22 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> The goal of this project is to make xembed system trays available in Plasma.
>
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] \
> available in Plasma which only supports StatusNotifierItem [2].
> Ideally we also want this to work in an xwayland session, making X system tray \
> icons available even when plasmashell only has a wayland connection.
> How it works (in theory)
>
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the embedded \
> container as left and right clicks
>
> Code is a mix of hacks and bodges bashing client apps into place, and I happily \
> acknowledge it looks pretty bad. Unfotunately most of it seems to be needed, but \
> I'd love to be proved wrong on most of it.
> ---
>
> CMakeLists changes are obviously currently wrong, I can strip half of find_packages \
> and I need an add_subdirectory in the root file, but it's easier for me to sync \
> with the separate repo mirror this way till we're close to merging. I expect this \
> to take quite some revisions.
>
> Diffs
> -----
>
> xembedsniproxy/CMakeLists.txt PRE-CREATION
> xembedsniproxy/Readme.md PRE-CREATION
> xembedsniproxy/fdoselectionmanager.h PRE-CREATION
> xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION
> xembedsniproxy/main.cpp PRE-CREATION
> xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION
> xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION
> xembedsniproxy/snidbus.h PRE-CREATION
> xembedsniproxy/snidbus.cpp PRE-CREATION
> xembedsniproxy/sniproxy.h PRE-CREATION
> xembedsniproxy/sniproxy.cpp PRE-CREATION
> xembedsniproxy/xcbutils.h PRE-CREATION
> xembedsniproxy/xembedsniproxy.desktop PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
--===============7194707772017689439==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125655/">https://git.reviewboard.kde.org/r/125655/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 16th, 2015, 12:34 p.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125655/diff/1/?file=411303#file411303line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">xembedsniproxy/sniproxy.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">42</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">// Q_PROPERTY(QString IconName READ IconName)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">43</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">// Q_PROPERTY(QString OverlayIconName READ \
OverlayIconName)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">44</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">// Q_PROPERTY(KDbusImageVector OverlayIconPixmap READ \
OverlayIconPixmap)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">45</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">// Q_PROPERTY(QString AttentionIconName READ \
AttentionIconName)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">46</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">// Q_PROPERTY(KDbusImageVector AttentionIconPixmap READ \
AttentionIconPixmap)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">47</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">// Q_PROPERTY(QString AttentionMovieName READ \
AttentionMovieName)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">48</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">// Q_PROPERTY(KDbusToolTipStruct ToolTip READ \
ToolTip)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">49</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">// Q_PROPERTY(QString IconThemePath READ \
IconThemePath)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">// Q_PROPERTY(QDBusObjectPath Menu READ Menu)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">hmm?</p></pre> </blockquote>
<p>On October 16th, 2015, 1:06 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ah \
right, I need some advice on here. </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">There are properties \
that exist in the SNI spec that I can't do anything with. Should I return blank \
values, or return DBus errors?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently I do the \
latter. Our plasma dataengine handles that fine, but I'm not sure which is more \
semantically correct.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">maybe dbus errors are more likely to crap out on other implementations? (no \
idea how to test this on unity)</p></pre> <br />
<p>- Marco</p>
<br />
<p>On October 16th, 2015, 11:22 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2015, 11:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The goal of this project is to make xembed system \
trays available in Plasma.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This is to allow legacy apps (xchat, \
pidgin, tuxguitar) etc. system trays[1] available in Plasma which only supports \
StatusNotifierItem [2].</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Ideally we also want this to work in an \
xwayland session, making X system tray icons available even when plasmashell only has \
a wayland connection.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">How it works (in theory)</p> <ul \
style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">We register a window as a system tray \
container</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">We render embeded windows composited offscreen</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">We render contents into an image and send this over DBus via the SNI \
protocol</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">XDamage events trigger a repaint</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Activate and context menu events are replyed via X send event into the \
embedded container as left and right clicks</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Code is a mix of hacks and bodges bashing client apps \
into place, and I happily acknowledge it looks pretty bad. Unfotunately most of it \
seems to be needed, but I'd love to be proved wrong on most of it.</p> <hr \
style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px \
solid #ddd;line-height: inherit;" /> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">CMakeLists changes are \
obviously currently wrong, I can strip half of find_packages and I need an \
add_subdirectory in the root file, but it's easier for me to sync with the separate \
repo mirror this way till we're close to merging. I expect this to take quite some \
revisions.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>xembedsniproxy/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/Readme.md <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/fdoselectionmanager.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/fdoselectionmanager.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/org.kde.StatusNotifierItem.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/org.kde.StatusNotifierWatcher.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/snidbus.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/snidbus.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/sniproxy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/sniproxy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/xcbutils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/xembedsniproxy.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125655/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7194707772017689439==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic