[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125433: kcm_kamera: Double calls to load() lead to strange scrollbars after savin
From: "Christian Butcher" <chrisb2244 () gmail ! com>
Date: 2015-10-08 7:44:30
Message-ID: 20151008074430.17685.70025 () mimi ! kde ! org
[Download RAW message or body]
--===============7295780234892169026==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125433/
-----------------------------------------------------------
(Updated Oct. 8, 2015, 7:44 a.m.)
Review request for KDE Graphics, Plasma and Marcus Meissner.
Changes
-------
Added images for each panel - shows the problem that Marcus references (I think) in \
his comment regarding the config panel
Repository: kamera
Description
-------
The displayGPSuccessDialogue(void) function calls load() as its last statement \
currently.
Documentation for the KCModule api (both \
[kde4](http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKCModule.html) and \
[frameworks](http://api.kde.org/frameworks-api/frameworks5-apidocs/kconfigwidgets/html/classKCModule.html)) \
informs the reader that load() is called at the end of construction - consequently it \
seems that the additional load() call leads to the function (which is implemented as \
KKameraConfig::load() ) being called twice.
[Bug 236844](https://bugs.kde.org/show_bug.cgi?id=236844) may be related but at least \
on my KF5 based system, this does not cause or prevent a crash, which is referenced \
in the bug.
Separately, COPYING-CMAKE-SCRIPTS is referenced by the FindGphoto2.cmake file, and \
seems to have missed the commit in \
[RR-125230](https://git.reviewboard.kde.org/r/125230/). If this was intentional, then \
my apologies for readding here, but if so, the FindGphoto2.cmake file will need \
changing in some way.
Diffs
-----
COPYING-CMAKE-SCRIPTS PRE-CREATION
kcontrol/kamera.cpp 2d8f61449a5a6f2650d864c864652ebea780a422
kcontrol/kameradevice.h b0ecb974f8fcb765228afe1965aeebab8e7656ed
Diff: https://git.reviewboard.kde.org/r/125433/diff/
Testing
-------
When the call is present, opening the Kamera KCM within systemsettings after saving \
changes and going back to the main systemsettings view leads to a strange set of \
scrollbars.
With the additional call removed, the KCM-Kamera opens properly on the second \
attempt, after saving changes.
As a camera to test, the first (in the scroll list) serial port camera is 'Achiever \
Digital Adc65'. 'Barbie' may be easier to find as the first entry for 'B', and is \
also more memorable... I used a serial camera, since then the kcm will load images \
even without a camera connected
File Attachments (updated)
----------------
scrollbars
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/28/74e8bd93-4c4a-4103-9fb1-7bd106258058__kcm1.png
Settings panel
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/1cc9a8bc-b8a9-40d4-986d-3ae91d040d17__Screenshot_20151008_164010.png
Information panel
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/13129de5-a4f3-4bd8-958b-205505a9d973__info.png
Test panel
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/176fcc11-c56a-4782-a827-88c0b0b75347__test.png
Config panel
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/afae96ce-7281-42b6-aaac-dc8b8299eb30__configure.png
Thanks,
Christian Butcher
--===============7295780234892169026==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125433/">https://git.reviewboard.kde.org/r/125433/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Graphics, Plasma and Marcus Meissner.</div>
<div>By Christian Butcher.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2015, 7:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added images for each panel - shows the problem that Marcus references \
(I think) in his comment regarding the config panel</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kamera
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The displayGPSuccessDialogue(void) function calls \
load() as its last statement currently.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Documentation for the \
KCModule api (both <a \
href="http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKCModule.html" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">kde4</a> and <a \
href="http://api.kde.org/frameworks-api/frameworks5-apidocs/kconfigwidgets/html/classKCModule.html" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">frameworks</a>) informs the reader that load() is called at the end of \
construction - consequently it seems that the additional load() call leads to the \
function (which is implemented as KKameraConfig::load() ) being called twice.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;"><a href="https://bugs.kde.org/show_bug.cgi?id=236844" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Bug \
236844</a> may be related but at least on my KF5 based system, this does not cause or \
prevent a crash, which is referenced in the bug.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Separately, COPYING-CMAKE-SCRIPTS is referenced by the FindGphoto2.cmake \
file, and seems to have missed the commit in <a \
href="https://git.reviewboard.kde.org/r/125230/" style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">RR-125230</a>. If this \
was intentional, then my apologies for readding here, but if so, the \
FindGphoto2.cmake file will need changing in some way.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When the call is present, opening the Kamera KCM \
within systemsettings after saving changes and going back to the main systemsettings \
view leads to a strange set of scrollbars.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">With the additional \
call removed, the KCM-Kamera opens properly on the second attempt, after saving \
changes.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As a camera to test, the first (in the scroll list) \
serial port camera is 'Achiever Digital Adc65'. 'Barbie' may be easier to find as the \
first entry for 'B', and is also more memorable... I used a serial camera, since then \
the kcm will load images even without a camera connected</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>COPYING-CMAKE-SCRIPTS <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcontrol/kamera.cpp <span style="color: \
grey">(2d8f61449a5a6f2650d864c864652ebea780a422)</span></li>
<li>kcontrol/kameradevice.h <span style="color: \
grey">(b0ecb974f8fcb765228afe1965aeebab8e7656ed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125433/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/28/74e8bd93-4c4a-4103-9fb1-7bd106258058__kcm1.png">scrollbars</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/1cc9a8bc-b8a9-40d4-986d-3ae91d040d17__Screenshot_20151008_164010.png">Settings \
panel</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/13129de5-a4f3-4bd8-958b-205505a9d973__info.png">Information \
panel</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/176fcc11-c56a-4782-a827-88c0b0b75347__test.png">Test \
panel</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/afae96ce-7281-42b6-aaac-dc8b8299eb30__configure.png">Config \
panel</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7295780234892169026==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic