[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available
From: "David Rosca" <nowrep () gmail ! com>
Date: 2015-10-01 8:11:42
Message-ID: 20151001081142.27965.53533 () mimi ! kde ! org
[Download RAW message or body]
--===============0010917502106230826==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Oct. 1, 2015, 6:01 a.m., Martin Gräßlin wrote:
> > Did you check KWin's udev helper classes? Instead of re-inventing the wheel it \
> > might be better to share the code in case it would be useful. It's in \
> > kwin.git/udev.h and udev.cpp
>
> David Rosca wrote:
> I did now, it doesn't seem to support device added/removed notifications.
Well, it does export UdevMonitor. Ok, I will rewrite it to use kwin's udev classes.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125465/#review86182
-----------------------------------------------------------
On Oct. 1, 2015, 8:05 a.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125465/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:05 a.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 346336
> https://bugs.kde.org/show_bug.cgi?id=346336
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> xcb-xinput is not available on some distributions (eg. Debian \
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227). This patch adds udev \
> device discovery to reapply settings when adding new keyboard / mouse.
>
> Diffs
> -----
>
> CMakeLists.txt 193238a
> cmake/modules/FindUDev.cmake PRE-CREATION
> kcms/keyboard/CMakeLists.txt 99f4bb3
> kcms/keyboard/config-keyboard.h.cmake PRE-CREATION
> kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5
> kcms/keyboard/kcm_add_layout_dialog.cpp 64551d9
> kcms/keyboard/kcm_keyboard_widget.h 5994ea4
> kcms/keyboard/tests/CMakeLists.txt 5d7a3e7
> kcms/keyboard/udev_helper.h PRE-CREATION
> kcms/keyboard/udev_helper.cpp PRE-CREATION
> kcms/keyboard/xinput_helper.h af70365
> kcms/keyboard/xinput_helper.cpp 0ad7e9c
> kcms/keyboard/xkb_rules.h ecebd6d
>
> Diff: https://git.reviewboard.kde.org/r/125465/diff/
>
>
> Testing
> -------
>
> Plugging in keyboard is now correctly recognized.
>
>
> Thanks,
>
> David Rosca
>
>
--===============0010917502106230826==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125465/">https://git.reviewboard.kde.org/r/125465/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 1st, 2015, 6:01 a.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Did you check KWin's udev helper classes? Instead of \
re-inventing the wheel it might be better to share the code in case it would be \
useful. It's in kwin.git/udev.h and udev.cpp</p></pre> </blockquote>
<p>On October 1st, 2015, 8:07 a.m. UTC, <b>David Rosca</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I did \
now, it doesn't seem to support device added/removed notifications.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, \
it does export UdevMonitor. Ok, I will rewrite it to use kwin's udev \
classes.</p></pre> <br />
<p>- David</p>
<br />
<p>On October 1st, 2015, 8:05 a.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated Oct. 1, 2015, 8:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=346336">346336</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">xcb-xinput is not available on some distributions (eg. \
Debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227). This patch adds \
udev device discovery to reapply settings when adding new keyboard / mouse.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Plugging in keyboard is now correctly \
recognized.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(193238a)</span></li>
<li>cmake/modules/FindUDev.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/keyboard/CMakeLists.txt <span style="color: grey">(99f4bb3)</span></li>
<li>kcms/keyboard/config-keyboard.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/keyboard/kcm_add_layout_dialog.h <span style="color: \
grey">(a2c0ac5)</span></li>
<li>kcms/keyboard/kcm_add_layout_dialog.cpp <span style="color: \
grey">(64551d9)</span></li>
<li>kcms/keyboard/kcm_keyboard_widget.h <span style="color: \
grey">(5994ea4)</span></li>
<li>kcms/keyboard/tests/CMakeLists.txt <span style="color: \
grey">(5d7a3e7)</span></li>
<li>kcms/keyboard/udev_helper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/keyboard/udev_helper.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/keyboard/xinput_helper.h <span style="color: grey">(af70365)</span></li>
<li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(0ad7e9c)</span></li>
<li>kcms/keyboard/xkb_rules.h <span style="color: grey">(ecebd6d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125465/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0010917502106230826==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic