[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-10-01 6:01:10
Message-ID: 20151001060110.16344.59767 () mimi ! kde ! org
[Download RAW message or body]
--===============3139384648495124188==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125465/#review86182
-----------------------------------------------------------
Did you check KWin's udev helper classes? Instead of re-inventing the wheel it might \
be better to share the code in case it would be useful. It's in kwin.git/udev.h and \
udev.cpp
kcms/keyboard/CMakeLists.txt (line 16)
<https://git.reviewboard.kde.org/r/125465/#comment59422>
please use a configure file (yes it should have been like that for the other as \
well, but when we touch it, it's a good idea to improve ;-) )
- Martin Gräßlin
On Sept. 30, 2015, 9:55 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125465/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 9:55 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 346336
> https://bugs.kde.org/show_bug.cgi?id=346336
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> xcb-xinput is not available on some distributions (eg. Debian \
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227). This patch adds udev \
> device discovery to reapply settings when adding new keyboard / mouse.
>
> Diffs
> -----
>
> CMakeLists.txt 193238a
> cmake/modules/FindUDev.cmake PRE-CREATION
> kcms/keyboard/CMakeLists.txt 99f4bb3
> kcms/keyboard/tests/CMakeLists.txt 5d7a3e7
> kcms/keyboard/udev_helper.h PRE-CREATION
> kcms/keyboard/udev_helper.cpp PRE-CREATION
> kcms/keyboard/xinput_helper.h af70365
> kcms/keyboard/xinput_helper.cpp 0ad7e9c
>
> Diff: https://git.reviewboard.kde.org/r/125465/diff/
>
>
> Testing
> -------
>
> Plugging in keyboard is now correctly recognized.
>
>
> Thanks,
>
> David Rosca
>
>
--===============3139384648495124188==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125465/">https://git.reviewboard.kde.org/r/125465/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Did \
you check KWin's udev helper classes? Instead of re-inventing the wheel it might be \
better to share the code in case it would be useful. It's in kwin.git/udev.h and \
udev.cpp</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125465/diff/1/?file=409087#file409087line16" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcms/keyboard/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">16</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">add_definitions</span><span class="p">(</span><span \
class="s">-DHAVE_UDEV=1</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">please use a configure file (yes it should have been like that for the \
other as well, but when we touch it, it's a good idea to improve ;-) )</p></pre> \
</div> </div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On September 30th, 2015, 9:55 p.m. CEST, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2015, 9:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=346336">346336</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">xcb-xinput is not available on some distributions (eg. \
Debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227). This patch adds \
udev device discovery to reapply settings when adding new keyboard / mouse.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Plugging in keyboard is now correctly \
recognized.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(193238a)</span></li>
<li>cmake/modules/FindUDev.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/keyboard/CMakeLists.txt <span style="color: grey">(99f4bb3)</span></li>
<li>kcms/keyboard/tests/CMakeLists.txt <span style="color: \
grey">(5d7a3e7)</span></li>
<li>kcms/keyboard/udev_helper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/keyboard/udev_helper.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/keyboard/xinput_helper.h <span style="color: grey">(af70365)</span></li>
<li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(0ad7e9c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125465/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3139384648495124188==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic