From kde-panel-devel Wed Sep 30 20:43:16 2015 From: "David Rosca" Date: Wed, 30 Sep 2015 20:43:16 +0000 To: kde-panel-devel Subject: Re: Review Request 125256: kded_keyboard: Fix restoring application/window specific layout settings Message-Id: <20150930204316.16344.49553 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144364581321966 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3510375645372628588==" --===============3510375645372628588== Content-Type: multipart/alternative; boundary="===============4714973700797948065==" --===============4714973700797948065== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125256/ ----------------------------------------------------------- (Updated Sept. 30, 2015, 8:43 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit 3768587fc6807e06dbf257dd51e2d9f2e42dd1b9 by David Rosca to branch Plasma/5.4. Bugs: 325572 https://bugs.kde.org/show_bug.cgi?id=325572 Repository: plasma-desktop Description ------- This removes the check if user has restore session on start option enabled, so the layout map is restored everytime. It also checks in LayoutMemory::laoutChanged if the changed keyboard layout is different from user configured to prevent clearing the layout map on startup. Diffs ----- kcms/keyboard/layout_memory.cpp 5ac6729 kcms/keyboard/layout_memory_persister.cpp da48739 Diff: https://git.reviewboard.kde.org/r/125256/diff/ Testing ------- Per-application (or per-window) layouts are now preserved. Thanks, David Rosca --===============4714973700797948065== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125256/

This change has been marked as submitted.

Review request for Plasma.

By David Rosca.

Updated Sept. 30, 2015, 8:43 p.m.

Changes

Submitted with commit 3768587fc6807e06dbf257dd51e2d9f2e42dd1b9 by David Rosca to branch Plasma/5.4.

Bugs: 325572

Repository: plasma-desktop

Description

This removes the check if user has restore session on start option enabled, so the layout map is restored everytime.

It also checks in LayoutMemory::laoutChanged if the changed keyboard layout is different from user configured to prevent clearing the layout map on startup.

Testing

Per-application (or per-window) layouts are now preserved.

Diffs

kcms/keyboard/layout_memory.cpp (5ac6729)
kcms/keyboard/layout_memory_persister.cpp (da48739)

View Diff

--===============4714973700797948065==-- --===============3510375645372628588== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============3510375645372628588==--