From kde-panel-devel Wed Sep 30 16:06:39 2015 From: "David Edmundson" Date: Wed, 30 Sep 2015 16:06:39 +0000 To: kde-panel-devel Subject: Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell Message-Id: <20150930160639.16344.97933 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144362922515766 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7637323545241184221==" --===============7637323545241184221== Content-Type: multipart/alternative; boundary="===============9040585774454067534==" --===============9040585774454067534== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review86170 ----------------------------------------------------------- shell/panelview.cpp (line 727) shouldn't this be "screen" as the first arg? - David Edmundson On Sept. 29, 2015, 5:38 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125451/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 5:38 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Now that everything's in place in Qt, we can do that. > > It basically removes all the translation layer between KScreen and QScreen. > > NOTE: This can't be merged until Qt 5.6 is a dependency. > > > Diffs > ----- > > shell/shellcorona.cpp 37d0534 > shell/shellcorona.h 0e6fe04 > shell/panelview.cpp c9b1968 > shell/panelview.h a41f988 > CMakeLists.txt 4fdcf1a > shell/CMakeLists.txt e17e4a3 > > Diff: https://git.reviewboard.kde.org/r/125451/diff/ > > > Testing > ------- > > Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There could be crashes, I just didn't find them :D) > > > Thanks, > > Aleix Pol Gonzalez > > --===============9040585774454067534== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/

shell/panelview.cpp (Diff revision 1)
void PanelView::showEvent(QShowEvent *event)
		727	connect(m_lastScreen.data(), &QScreen::geometryChanged, this, &PanelView::updateStruts);

shouldn't this be "screen" as the first arg?

- David Edmundson

On September 29th, 2015, 5:38 p.m. UTC, Aleix Pol Gonzalez wrote:

Review request for Plasma.

By Aleix Pol Gonzalez.

Updated Sept. 29, 2015, 5:38 p.m.

Repository: plasma-workspace

Description

Now that everything's in place in Qt, we can do that.

It basically removes all the translation layer between KScreen and QScreen.

NOTE: This can't be merged until Qt 5.6 is a dependency.

Testing

Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There could be crashes, I just didn't find them :D)

Diffs

shell/shellcorona.cpp (37d0534)
shell/shellcorona.h (0e6fe04)
shell/panelview.cpp (c9b1968)
shell/panelview.h (a41f988)
CMakeLists.txt (4fdcf1a)
shell/CMakeLists.txt (e17e4a3)

--===============9040585774454067534==-- --===============7637323545241184221== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7637323545241184221==--