'Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2015-09-30 15:27:15
Message-ID: 20150930152715.16344.14494 () mimi ! kde ! org
[Download RAW message or body]

--===============8434991230471086488==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/#review86169
-----------------------------------------------------------

+1 as well. KScreen should only be used to configure the screen setup, not to query \
available screens.

Thanks a lot for this work, Aleix, especially getting our needs upstreamed into Qt.

- Sebastian Kügler

On Sept. 29, 2015, 5:38 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125451/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 5:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Now that everything's in place in Qt, we can do that.
> 
> It basically removes all the translation layer between KScreen and QScreen.
> 
> NOTE: This can't be merged until Qt 5.6 is a dependency.
> 
> 
> Diffs
> -----
> 
> shell/shellcorona.cpp 37d0534 
> shell/shellcorona.h 0e6fe04 
> shell/panelview.cpp c9b1968 
> shell/panelview.h a41f988 
> CMakeLists.txt 4fdcf1a 
> shell/CMakeLists.txt e17e4a3 
> 
> Diff: https://git.reviewboard.kde.org/r/125451/diff/
> 
> 
> Testing
> -------
> 
> Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There \
> could be crashes, I just didn't find them :D) 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
> 

--===============8434991230471086488==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125451/">https://git.reviewboard.kde.org/r/125451/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 as \
well. KScreen should only be used to configure the screen setup, not to query \
available screens.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Thanks a lot for this work, Aleix, \
especially getting our needs upstreamed into Qt.</p></pre>  <br />

<p>- Sebastian Kügler</p>

<br />
<p>On September 29th, 2015, 5:38 p.m. UTC, Aleix Pol Gonzalez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated Sept. 29, 2015, 5:38 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now that everything's in place in Qt, we can do \
that.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It basically removes all the translation layer between \
KScreen and QScreen.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">NOTE: This can't be merged until Qt 5.6 \
is a dependency.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hands-on testing, it's been working quite fluid and I \
couldn't find a crash. (There could be crashes, I just didn't find them :D)</p></pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/shellcorona.cpp <span style="color: grey">(37d0534)</span></li>

 <li>shell/shellcorona.h <span style="color: grey">(0e6fe04)</span></li>

 <li>shell/panelview.cpp <span style="color: grey">(c9b1968)</span></li>

 <li>shell/panelview.h <span style="color: grey">(a41f988)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(4fdcf1a)</span></li>

 <li>shell/CMakeLists.txt <span style="color: grey">(e17e4a3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125451/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8434991230471086488==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 