'Re: Review Request 125453: introduce SkipsTaskbar'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125453: introduce SkipsTaskbar
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-09-30 14:55:08
Message-ID: 20150930145508.16344.54937 () mimi ! kde ! org
[Download RAW message or body]

--===============7324920964910076536==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125453/
-----------------------------------------------------------

(Updated Sept. 30, 2015, 2:55 p.m.)

Status
------

This change has been marked as submitted.

Review request for kwin and Plasma.

Changes
-------

Submitted with commit 140c1860161aac4aa81fb9cec3c0b55d9bf0ad74 by Marco Martin to \
branch master.

Repository: kwayland

Description
-------

support the skiptTaskbar property in the window model
that property is set client side by
PlasmaShell::setSkipsTaskbar

Diffs
-----

  src/client/plasmashell.h 6692300 
  src/client/plasmashell.cpp 4daaecf 
  src/client/plasmawindowmanagement.h 6e36def 
  src/client/plasmawindowmanagement.cpp f6279d9 
  src/client/plasmawindowmodel.h 49a2115 
  src/client/plasmawindowmodel.cpp ceba6ce 
  src/client/protocols/plasma-shell.xml 7d33236 
  src/client/protocols/plasma-window-management.xml a5bd639 
  src/client/registry.cpp 9fa6f64 
  src/server/plasmashell_interface.h 228cbb1 
  src/server/plasmashell_interface.cpp 32fd389 
  src/server/plasmawindowmanagement_interface.h c348d65 
  src/server/plasmawindowmanagement_interface.cpp d6c71ae 

Diff: https://git.reviewboard.kde.org/r/125453/diff/

Testing
-------

Thanks,

Marco Martin

--===============7324920964910076536==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125453/">https://git.reviewboard.kde.org/r/125453/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Sept. 30, 2015, 2:55 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 140c1860161aac4aa81fb9cec3c0b55d9bf0ad74 by Marco \
Martin to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">support the skiptTaskbar property in the window model that property is \
set client side by PlasmaShell::setSkipsTaskbar</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/client/plasmashell.h <span style="color: grey">(6692300)</span></li>

 <li>src/client/plasmashell.cpp <span style="color: grey">(4daaecf)</span></li>

 <li>src/client/plasmawindowmanagement.h <span style="color: \
grey">(6e36def)</span></li>

 <li>src/client/plasmawindowmanagement.cpp <span style="color: \
grey">(f6279d9)</span></li>

 <li>src/client/plasmawindowmodel.h <span style="color: grey">(49a2115)</span></li>

 <li>src/client/plasmawindowmodel.cpp <span style="color: grey">(ceba6ce)</span></li>

 <li>src/client/protocols/plasma-shell.xml <span style="color: \
grey">(7d33236)</span></li>

 <li>src/client/protocols/plasma-window-management.xml <span style="color: \
grey">(a5bd639)</span></li>

 <li>src/client/registry.cpp <span style="color: grey">(9fa6f64)</span></li>

 <li>src/server/plasmashell_interface.h <span style="color: \
grey">(228cbb1)</span></li>

 <li>src/server/plasmashell_interface.cpp <span style="color: \
grey">(32fd389)</span></li>

 <li>src/server/plasmawindowmanagement_interface.h <span style="color: \
grey">(c348d65)</span></li>

 <li>src/server/plasmawindowmanagement_interface.cpp <span style="color: \
grey">(d6c71ae)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125453/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7324920964910076536==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 