[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125454: supports kwayland skipsTaskbar
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-09-30 6:00:48
Message-ID: 20150930060048.16344.58013 () mimi ! kde ! org
[Download RAW message or body]
--===============1603239410855124094==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125454/#review86143
-----------------------------------------------------------
Ship it!
as expected pretty much straight forward. Please commit once kwayland part is done.
- Martin Gräßlin
On Sept. 29, 2015, 8:26 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125454/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 8:26 p.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> read the skipTaskbar property from plasmashellsurface
> and set it accordingly in the corresponding PlasmaWindow
> for the model
>
>
> Diffs
> -----
>
> abstract_client.cpp bb4f14dac01fc308587d689dcf95f091c5cfac5a
> shell_client.cpp 2784eb2f4f1b5d9000be3d5e8fb9af3c371959f3
>
> Diff: https://git.reviewboard.kde.org/r/125454/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============1603239410855124094==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125454/">https://git.reviewboard.kde.org/r/125454/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">as \
expected pretty much straight forward. Please commit once kwayland part is \
done.</p></pre> <br />
<p>- Martin Gräßlin</p>
<br />
<p>On September 29th, 2015, 8:26 p.m. CEST, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2015, 8:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">read the skipTaskbar property from plasmashellsurface and set it \
accordingly in the corresponding PlasmaWindow for the model</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>abstract_client.cpp <span style="color: \
grey">(bb4f14dac01fc308587d689dcf95f091c5cfac5a)</span></li>
<li>shell_client.cpp <span style="color: \
grey">(2784eb2f4f1b5d9000be3d5e8fb9af3c371959f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125454/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1603239410855124094==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic