[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item
From: "Takahiro Hashimoto" <kenya888 () gmail ! com>
Date: 2015-09-30 1:53:08
Message-ID: 20150930015308.16344.95229 () mimi ! kde ! org
[Download RAW message or body]
--===============1674592417965429308==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125402/
-----------------------------------------------------------
(Updated 9月 30, 2015, 10:53 a.m.)
Review request for Plasma and Eike Hein.
Changes
-------
Add dependency https://git.reviewboard.kde.org/r/125443/ for good UX. I'd like to \
commit/push this patch after it is resolved. Thanks you all again for great help:)
Repository: plasma-desktop
Description
-------
Now the label of app is elided on Kicker dashboard. It's good, of course.
We sometimes want to see full text of app name, for example when the same icon is \
used for some apps or a app which we see first on the dashboard.
PlasmaCore.ToolTipArea is good solution, I think.
Diffs
-----
applets/kicker/package/contents/ui/ItemGridDelegate.qml 3de7aeb
Diff: https://git.reviewboard.kde.org/r/125402/diff/
Testing
-------
Build and Test on latest.
1. Open dashboard
2. make mouse hover on app cell.
ToolTip is shown and hide on click/press enter on app cell and closing dashboard.
File Attachments
----------------
dash_tooltip screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/26/f02936e2-a438-4ec4-9189-10e59fd84965__kickerdash_tooltip.png
Tooltip design with tooltipDelegate
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/30/10119564-04e1-4a00-a34d-fc3ea8227761__kickerdash_tooltip2.png
Thanks,
Takahiro Hashimoto
--===============1674592417965429308==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125402/">https://git.reviewboard.kde.org/r/125402/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Eike Hein.</div>
<div>By Takahiro Hashimoto.</div>
<p style="color: grey;"><i>Updated 9月 30, 2015, 10:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add dependency https://git.reviewboard.kde.org/r/125443/ for good UX. \
I'd like to commit/push this patch after it is resolved. Thanks you all again for \
great help:)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now the label of app is elided on Kicker dashboard. \
It's good, of course.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">We sometimes want to see full text of \
app name, for example when the same icon is used for some apps or a app which we see \
first on the dashboard.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">PlasmaCore.ToolTipArea is good \
solution, I think.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build and Test on latest.</p> <ol style="padding: \
0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Open dashboard</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">make \
mouse hover on app cell.</li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ToolTip is shown and hide on click/press enter on app \
cell and closing dashboard.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kicker/package/contents/ui/ItemGridDelegate.qml <span style="color: \
grey">(3de7aeb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125402/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/26/f02936e2-a438-4ec4-9189-10e59fd84965__kickerdash_tooltip.png">dash_tooltip \
screenshot</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/30/10119564-04e1-4a00-a34d-fc3ea8227761__kickerdash_tooltip2.png">Tooltip \
design with tooltipDelegate</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1674592417965429308==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic