[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125443: Make tooltip dialog hidden on the cursor entering the inactive ToolTipAre
From: "Takahiro Hashimoto" <kenya888 () gmail ! com>
Date: 2015-09-30 1:48:38
Message-ID: 20150930014838.16344.21095 () mimi ! kde ! org
[Download RAW message or body]
--===============8629156930984418053==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125443/
-----------------------------------------------------------
(Updated 9月 30, 2015, 10:48 a.m.)
Review request for Plasma.
Changes
-------
upload tests/tooltip.qml screenshot
Repository: plasma-framework
Description
-------
Now PlasmaCore.ToolTipArea can control status of active/inactive.
When a ToolTip dialog is visible and making mouse move to another inactive \
ToolTipArea, it remains unnaturally for a while.
I attached a urgy test program to reproduce this behavior. The instruction \
to reproduce is:
1.run qmlscene tooltip_hide.qml
2. make mouse cursor on the cell named "name1" (or any odd numbered one)
3. move the cursor to a even numberd cell like "name2"
It results the "tip1" tooltip remains for a long time (current spec is \
4000ms)
I think it would be better when a mouse entered into an inatcive \
ToolTipArea, the global tooltip dialog is dismissed soon. This patch is the \
implementation of this behavior.
I cannot check all side-effect to change this behavior. Many guys adivce \
are welcomed:)
Here's my reference use case: https://git.reviewboard.kde.org/r/125402/
Diffs
-----
src/declarativeimports/core/tooltip.cpp 3ffcdba
tests/tooltip.qml b153188
Diff: https://git.reviewboard.kde.org/r/125443/diff/
Testing
-------
Apply patch and build and test on master.
Tested with my test program attached this review request. Works fine to me.
File Attachments (updated)
----------------
test program
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/29/c1653f27-c5b2-46e4-85bb-69a9d02720c5__tooltip_hide.qml
update current tooltip test program
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/30/2c2a8d31-c5ec-48ed-aeb1-90a2a67596f1__ss_tooltip_test.png
Thanks,
Takahiro Hashimoto
--===============8629156930984418053==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125443/">https://git.reviewboard.kde.org/r/125443/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Takahiro Hashimoto.</div>
<p style="color: grey;"><i>Updated 9月 30, 2015, 10:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">upload tests/tooltip.qml screenshot</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Now PlasmaCore.ToolTipArea \
can control status of active/inactive.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">When a ToolTip dialog is visible and making mouse move to another \
inactive ToolTipArea, it remains unnaturally for a while.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I attached a urgy test program to reproduce \
this behavior. The instruction to reproduce is:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">1.run qmlscene tooltip_hide.qml 2. make mouse cursor on the cell \
named "name1" (or any odd numbered one) 3. move the cursor to a even \
numberd cell like "name2"</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It results \
the "tip1" tooltip remains for a long time (current spec is 4000ms)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think it would be better when a mouse \
entered into an inatcive ToolTipArea, the global tooltip dialog is \
dismissed soon. This patch is the implementation of this behavior.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I cannot check all side-effect to change \
this behavior. Many guys adivce are welcomed:)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Here's my reference use case: \
https://git.reviewboard.kde.org/r/125402/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Apply patch and build and \
test on master.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Tested with my test program \
attached this review request. Works fine to me.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/tooltip.cpp <span style="color: \
grey">(3ffcdba)</span></li>
<li>tests/tooltip.qml <span style="color: grey">(b153188)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125443/diff/" \
style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File \
Attachments (updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/29/c1653f27-c5b2-46e4-85bb-69a9d02720c5__tooltip_hide.qml">test \
program</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/30/2c2a8d31-c5ec-48ed-aeb1-90a2a67596f1__ss_tooltip_test.png">update \
current tooltip test program</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8629156930984418053==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic