'Re: Review Request 125395: Mutex around usage of m_connectedEvents which may be called from any thre'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125395: Mutex around usage of m_connectedEvents which may be called from any thre
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-09-29 21:55:47
Message-ID: 20150929215547.16344.43265 () mimi ! kde ! org
[Download RAW message or body]

--===============7074280011814947430==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Sept. 29, 2015, 5:15 p.m., Daniel Nicoletti wrote:
> > Why is it better? I found the first less intrusive, simpler and likely faster

The first one wouldn't be faster. We had the queued connection on start() on the \
timer anyway whereas with patch 2 it's a direct call. So that's the same number of \
meta object table lookups, and this one doesn't have the the potential for one thread \
to be locked waiting.

I'm pretty indifferent. I'll push whichever one you prefer.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125395/#review86120
-----------------------------------------------------------

On Sept. 29, 2015, 3:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125395/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 3:48 p.m.)
> 
> 
> Review request for Plasma, Daniel Nicoletti and Harald Sitter.
> 
> 
> Repository: print-manager
> 
> 
> Description
> -------
> 
> m_connectedEvents is modified in connectNotify which according to the
> docs will be called from the thread of the caller, not this.
> 
> A mutex around all places that use/modify it should prevent print manager from \
> making plasmashell crash. 
> BUG: 345862
> 
> 
> Diffs
> -----
> 
> libkcups/KCupsConnection.h f61ccb53078766e7f5e96dedec879b52b9083b66 
> libkcups/KCupsConnection.cpp 482a0bcc9afdee9e0fa131da158988d349dd0da6 
> 
> Diff: https://git.reviewboard.kde.org/r/125395/diff/
> 
> 
> Testing
> -------
> 
> Applet still loads..though I don't have any printers, so can't test too much.
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============7074280011814947430==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125395/">https://git.reviewboard.kde.org/r/125395/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On September 29th, 2015, 5:15 p.m. UTC, <b>Daniel \
Nicoletti</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Why is it better? I found the first less intrusive, \
simpler and likely faster</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
first one wouldn't be faster. We had the queued connection on start() on the timer \
anyway whereas with patch 2 it's a direct call. So that's the same number of meta \
object table lookups, and this one doesn't have the the potential for one thread to \
be locked waiting.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I'm pretty indifferent. I'll push \
whichever one you prefer.</p></pre> <br />

<p>- David</p>

<br />
<p>On September 29th, 2015, 3:48 p.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Daniel Nicoletti and Harald Sitter.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Sept. 29, 2015, 3:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
print-manager
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">m_connectedEvents is modified in connectNotify which \
according to the docs will be called from the thread of the caller, not this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A mutex around all places that use/modify it should \
prevent print manager from making plasmashell crash.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: \
345862</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Applet still loads..though I don't have any printers, \
so can't test too much.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libkcups/KCupsConnection.h <span style="color: \
grey">(f61ccb53078766e7f5e96dedec879b52b9083b66)</span></li>

 <li>libkcups/KCupsConnection.cpp <span style="color: \
grey">(482a0bcc9afdee9e0fa131da158988d349dd0da6)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125395/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7074280011814947430==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 