[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125437: Made new applet icons for all applets
From: "kainz.a" <kainz.a () gmail ! com>
Date: 2015-09-29 14:03:41
Message-ID: CAFryEO7dg_WtSXhwRZAn2sfWspY96eEncpxw3wM=T6iGQ79fWw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
2015-09-29 15:38 GMT+02:00 Sebastian Kügler <sebas@kde.org>:
> On Tue, 29 Sep 2015 15:26:04 +0200
> "kainz.a" <kainz.a@gmail.com> wrote:
>
> > 2015-09-28 23:24 GMT+02:00 Sebastian Kügler <sebas@kde.org>:
> >
> > > On Monday, September 28, 2015 20:33:33 Marco Martin wrote:
> > > > On Monday 28 September 2015, andreas kainz wrote:
> > > > > > On Sept. 28, 2015, 2:29 p.m., Eike Hein wrote:
> > > > > > > applets/showActivityManager/package/metadata.desktop, line
> > > > > > > 114 <
> > > https://git.reviewboard.kde.org/r/125437/diff/1/?file=408607#file4086
> > > > > > > 0
> > > > > > > 7line114>
> > > > > > >
> > > > > > > The applet icons aren't really part of the icon theme,
> > > > > > > but the icon
> > > > > > > spec does say "As a further restriction, all icon names
> > > > > > > may
> > > only
> > > > > > > contain lowercase letters, numbers, underscore, dash,
> > > > > > > or period characters." - maybe we should keep the lowercase
> > > > > > > restriction
> > > for
> > > > > > > our icon assets? It's not a big deal though.
> > > > >
> > > > > should I remove the org.kde.? I would prefere icon names like
> > > > >
> > > > > plasma-showactivitymanager
> > > > >
> > > > > according to our wiki
> > > > >
> > >
> https://github.com/NitruxSA/breeze-icon-theme/wiki/Icon-naming-and-categor
> > > > > ization-guidelines-in-Breeze
> > > >
> > > > fine with me, in that case is perhaps better to have
> > > > plasma-applet-showactivitymanager
> > > > to be really sure all names won't clash with something else some
> > > > day
> > >
> > > I'd prefer having the plugin name (so keeping the org.kde prefix)
> > > also used in
> > > the icon name, it's way easier to find the icon programmatically
> > > this way (even if we define it in the .desktop file).
> > >
> > >
> > I'd prefere the naming of app specific icons according to our
> > guidelines. hope it would work for you too Sebastian. I understand
> > that it is difficult to find the right widget name in the plasma
> > source code, cause the names are quite different, but this is no icon
> > name problem and of course widgets should have the same icon type
> > than all other apps.
> >
> > plasma-applet-showactivitymanager
>
> Which guidelines? The one hard guideline we have is plugin names. Dots
> are OK in icon names according to Eike, so why would we invent yet
> another name?
>
https://github.com/NitruxSA/breeze-icon-theme/wiki/Icon-naming-and-categorization-guidelines-in-Breeze
> --
> sebas
>
> Sebastian Kügler | http://vizZzion.org | http://kde.org
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
[Attachment #5 (text/html)]
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-09-29 \
15:38 GMT+02:00 Sebastian Kügler <span dir="ltr"><<a href="mailto:sebas@kde.org" \
target="_blank">sebas@kde.org</a>></span>:<br><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5">On Tue, 29 Sep 2015 \
15:26:04 +0200<br> "kainz.a" <<a \
href="mailto:kainz.a@gmail.com">kainz.a@gmail.com</a>> wrote:<br> <br>
> 2015-09-28 23:24 GMT+02:00 Sebastian Kügler <<a \
href="mailto:sebas@kde.org">sebas@kde.org</a>>:<br> ><br>
> > On Monday, September 28, 2015 20:33:33 Marco Martin wrote:<br>
> > > On Monday 28 September 2015, andreas kainz wrote:<br>
> > > > > On Sept. 28, 2015, 2:29 p.m., Eike Hein wrote:<br>
> > > > > > applets/showActivityManager/package/metadata.desktop, \
line<br> > > > > > > 114 <<br>
> > <a href="https://git.reviewboard.kde.org/r/125437/diff/1/?file=408607#file4086" \
rel="noreferrer" target="_blank">https://git.reviewboard.kde.org/r/125437/diff/1/?file=408607#file4086</a><br>
> > > > > > 0<br>
> > > > > > 7line114><br>
> > > > > ><br>
> > > > > > The applet icons aren't really part of the \
icon theme,<br> > > > > > > but the icon<br>
> > > > > > spec does say "As a further restriction, \
all icon names<br> > > > > > > may<br>
> > only<br>
> > > > > > contain lowercase letters, numbers, underscore, \
dash,<br> > > > > > > or period characters." - maybe we should \
keep the lowercase<br> > > > > > > restriction<br>
> > for<br>
> > > > > > our icon assets? It's not a big deal \
though.<br> > > > ><br>
> > > > should I remove the org.kde.? I would prefere icon names like<br>
> > > ><br>
> > > > plasma-showactivitymanager<br>
> > > ><br>
> > > > according to our wiki<br>
> > > ><br>
> > <a href="https://github.com/NitruxSA/breeze-icon-theme/wiki/Icon-naming-and-categor" \
rel="noreferrer" target="_blank">https://github.com/NitruxSA/breeze-icon-theme/wiki/Icon-naming-and-categor</a><br>
> > > > ization-guidelines-in-Breeze<br>
> > ><br>
> > > fine with me, in that case is perhaps better to have<br>
> > > plasma-applet-showactivitymanager<br>
> > > to be really sure all names won't clash with something else \
some<br> > > > day<br>
> ><br>
> > I'd prefer having the plugin name (so keeping the org.kde prefix)<br>
> > also used in<br>
> > the icon name, it's way easier to find the icon programmatically<br>
> > this way (even if we define it in the .desktop file).<br>
> ><br>
> ><br>
> I'd prefere the naming of app specific icons according to our<br>
> guidelines. hope it would work for you too Sebastian. I understand<br>
> that it is difficult to find the right widget name in the plasma<br>
> source code, cause the names are quite different, but this is no icon<br>
> name problem and of course widgets should have the same icon type<br>
> than all other apps.<br>
><br>
> plasma-applet-showactivitymanager<br>
<br>
</div></div>Which guidelines? The one hard guideline we have is plugin names. \
Dots<br> are OK in icon names according to Eike, so why would we invent yet<br>
another name?<br></blockquote><div><br><a \
href="https://github.com/NitruxSA/breeze-icon-theme/wiki/Icon-naming-and-categorizatio \
n-guidelines-in-Breeze">https://github.com/NitruxSA/breeze-icon-theme/wiki/Icon-naming-and-categorization-guidelines-in-Breeze</a><br> \
<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div class=""><div \
class="h5">--<br> sebas<br>
<br>
Sebastian Kügler | <a href="http://vizZzion.org" rel="noreferrer" \
target="_blank">http://vizZzion.org</a> | <a href="http://kde.org" \
rel="noreferrer" target="_blank">http://kde.org</a><br> <br>
_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" rel="noreferrer" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
</div></div></blockquote></div><br></div></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic