[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item
From: "Eike Hein" <hein () kde ! org>
Date: 2015-09-29 13:12:54
Message-ID: 20150929131254.16344.68704 () mimi ! kde ! org
[Download RAW message or body]
--===============4355168512468633885==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125402/#review86108
-----------------------------------------------------------
applets/kicker/package/contents/ui/ItemGridDelegate.qml (line 139)
<https://git.reviewboard.kde.org/r/125402/#comment59383>
It's better to use TextMetrics :)
- Eike Hein
On Sept. 29, 2015, 6:01 a.m., Takahiro Hashimoto wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125402/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 6:01 a.m.)
>
>
> Review request for Plasma and Eike Hein.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Now the label of app is elided on Kicker dashboard. It's good, of course.
>
> We sometimes want to see full text of app name, for example when the same icon is \
> used for some apps or a app which we see first on the dashboard.
> PlasmaCore.ToolTipArea is good solution, I think.
>
>
> Diffs
> -----
>
> applets/kicker/package/contents/ui/ItemGridDelegate.qml 3de7aeb
>
> Diff: https://git.reviewboard.kde.org/r/125402/diff/
>
>
> Testing
> -------
>
> Build and Test on latest.
>
> 1. Open dashboard
> 2. make mouse hover on app cell.
>
> ToolTip is shown and hide on click/press enter on app cell and closing dashboard.
>
>
> File Attachments
> ----------------
>
> dash_tooltip screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/26/f02936e2-a438-4ec4-9189-10e59fd84965__kickerdash_tooltip.png
>
>
> Thanks,
>
> Takahiro Hashimoto
>
>
--===============4355168512468633885==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125402/">https://git.reviewboard.kde.org/r/125402/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125402/diff/2/?file=408642#file408642line139" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/kicker/package/contents/ui/ItemGridDelegate.qml</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">139</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">Text</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's \
better to use TextMetrics :)</p></pre> </div>
</div>
<br />
<p>- Eike Hein</p>
<br />
<p>On September 29th, 2015, 6:01 a.m. UTC, Takahiro Hashimoto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Eike Hein.</div>
<div>By Takahiro Hashimoto.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2015, 6:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now the label of app is elided on Kicker dashboard. \
It's good, of course.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">We sometimes want to see full text of \
app name, for example when the same icon is used for some apps or a app which we see \
first on the dashboard.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">PlasmaCore.ToolTipArea is good \
solution, I think.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build and Test on latest.</p> <ol style="padding: \
0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Open dashboard</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">make \
mouse hover on app cell.</li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ToolTip is shown and hide on click/press enter on app \
cell and closing dashboard.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kicker/package/contents/ui/ItemGridDelegate.qml <span style="color: \
grey">(3de7aeb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125402/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/26/f02936e2-a438-4ec4-9189-10e59fd84965__kickerdash_tooltip.png">dash_tooltip \
screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4355168512468633885==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic