'Re: Review Request 122528: [screenlocker] Grab XServer while establishing the grab'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122528: [screenlocker] Grab XServer while establishing the grab
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2015-09-29 8:43:23
Message-ID: 20150929084323.8863.63599 () mimi ! kde ! org
[Download RAW message or body]

--===============7078067743865344596==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122528/
-----------------------------------------------------------

(Updated Sept. 29, 2015, 8:43 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit cfef8bf23d361624bab39dde1cf4a3ccc56fcd81 by Martin Gräßlin to \
branch master.

Repository: plasma-workspace

Description
-------

By grabbing the XServer we can ensure that no other client is
sending X events. This eliminates a possible timing attack in
the time frame between grabbing keyboard and pointer.

At the same time the waiting and try again becomes useless as the
XServer is grabbed and no other client could release the hold
input device grab.

Diffs
-----

  ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 

Diff: https://git.reviewboard.kde.org/r/122528/diff/

Testing
-------

Thanks,

Martin Gräßlin

--===============7078067743865344596==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122528/">https://git.reviewboard.kde.org/r/122528/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Sept. 29, 2015, 8:43 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit cfef8bf23d361624bab39dde1cf4a3ccc56fcd81 by Martin \
Gräßlin to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">By grabbing the XServer we can ensure that no other client is sending X \
events. This eliminates a possible timing attack in the time frame between grabbing \
keyboard and pointer.

At the same time the waiting and try again becomes useless as the
XServer is grabbed and no other client could release the hold
input device grab.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(e23b50fbcaac659bb6ef1b36a4de6efc63573978)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122528/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7078067743865344596==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 