'Re: Review Request 125437: Made new applet icons for all applets'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-panel-devel
Subject: Re: Review Request 125437: Made new applet icons for all applets
From: "andreas kainz" <kainz.a () gmail ! com>
Date: 2015-09-28 18:04:31
Message-ID: 20150928180431.8863.39634 () mimi ! kde ! org
[Download RAW message or body]

--===============7501026430975469531==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Sept. 28, 2015, 2:29 p.m., Eike Hein wrote:
> > applets/showActivityManager/package/metadata.desktop, line 114
> > <https://git.reviewboard.kde.org/r/125437/diff/1/?file=408607#file408607line114>
> > 
> > The applet icons aren't really part of the icon theme, but the icon spec does say \
> > "As a further restriction, all icon names may only contain lowercase letters, \
> > numbers, underscore, dash, or period characters." - maybe we should keep the \
> > lowercase restriction for our icon assets? It's not a big deal though.

should I remove the org.kde.? I would prefere icon names like 

plasma-showactivitymanager

according to our wiki \
https://github.com/NitruxSA/breeze-icon-theme/wiki/Icon-naming-and-categorization-guidelines-in-Breeze

- andreas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125437/#review86049
-----------------------------------------------------------

On Sept. 28, 2015, 2:33 p.m., andreas kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125437/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 2:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Hi,
> 
> I made for all widgets applet icons in 256 px so that the user can see how the \
> widget should look like in the future. will fit into the widget explorer. 
> when the widgets will work for you I made them for plasma-breeze-dark and maybe for \
> plasma-oxygen (maybe) 
> The icon will be used in the widget-explorer sidebar and at use alternative widget, \
> ....  
> https://git.reviewboard.kde.org/r/125135/
> 
> 
> Diffs
> -----
> 
> applets/icontasks/metadata.desktop fbaabbc 
> applets/kicker/package/metadata.desktop a6e7d7a 
> applets/kickoff/package/metadata.desktop d9c9a3c 
> applets/pager/package/metadata.desktop 148601e 
> applets/showActivityManager/package/metadata.desktop 3295a1b 
> applets/taskmanager/package/metadata.desktop e3b2f4b 
> applets/window-list/metadata.desktop a532d45 
> 
> Diff: https://git.reviewboard.kde.org/r/125437/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> andreas kainz
> 
> 

--===============7501026430975469531==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125437/">https://git.reviewboard.kde.org/r/125437/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On September 28th, 2015, 2:29 p.m. UTC, <b>Eike \
Hein</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/125437/diff/1/?file=408607#file408607line114" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/showActivityManager/package/metadata.desktop</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">114</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; \
">Icon=preferences-activities</pre></td>  <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">114</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; \
">Icon=org.kde.plasma.showActivityManager</pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
applet icons aren't really part of the icon theme, but the icon spec does say "As a \
further restriction, all icon names may only contain lowercase letters, numbers, \
underscore, dash, or period characters." - maybe we should keep the lowercase \
restriction for our icon assets? It's not a big deal though.</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should I remove the org.kde.? I would prefere icon names like plasma-showactivitymanager according to our wiki \
https://github.com/NitruxSA/breeze-icon-theme/wiki/Icon-naming-and-categorization-guidelines-in-Breeze</pre>

<p>- andreas</p>

<br />
<p>On September 28th, 2015, 2:33 p.m. UTC, andreas kainz wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By andreas kainz.</div>

<p style="color: grey;"><i>Updated Sept. 28, 2015, 2:33 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi,</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I made for all widgets \
applet icons in 256 px so that the user can see how the widget should look like in \
the future. will fit into the widget explorer.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">when \
the widgets will work for you I made them for plasma-breeze-dark and maybe for \
plasma-oxygen (maybe)</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The icon will be used in the \
widget-explorer sidebar and at use alternative widget, .... </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">https://git.reviewboard.kde.org/r/125135/</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/icontasks/metadata.desktop <span style="color: \
grey">(fbaabbc)</span></li>

 <li>applets/kicker/package/metadata.desktop <span style="color: \
grey">(a6e7d7a)</span></li>

 <li>applets/kickoff/package/metadata.desktop <span style="color: \
grey">(d9c9a3c)</span></li>

 <li>applets/pager/package/metadata.desktop <span style="color: \
grey">(148601e)</span></li>

 <li>applets/showActivityManager/package/metadata.desktop <span style="color: \
grey">(3295a1b)</span></li>

 <li>applets/taskmanager/package/metadata.desktop <span style="color: \
grey">(e3b2f4b)</span></li>

 <li>applets/window-list/metadata.desktop <span style="color: \
grey">(a532d45)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125437/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7501026430975469531==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 