'Re: Review Request 125440: Use Complementary color group for Folder View'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125440: Use Complementary color group for Folder View
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-09-28 17:57:01
Message-ID: 20150928175701.8863.80589 () mimi ! kde ! org
[Download RAW message or body]

--===============4996861144492273041==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125440/#review86059
-----------------------------------------------------------

Ship it!

+2 from me if VDG is ok too

- Marco Martin

On Sept. 28, 2015, 5:33 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125440/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 5:33 p.m.)
> 
> 
> Review request for Plasma, Andrew Lake and Jens Reuterberg.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> In order to increase contrast against wallpapers, the item delegate for the Folder \
> View desktop containment currently uses a rounded rect behind the text label. The \
> rounded rect uses the theme's normal text color at opacity 0.4 while the text label \
> uses the theme's background color at opacity 1.0, to essentially invert the regular \
> colors. This was originally submitted as a patch by the VDG. 
> It's been brought to my attention that this isn't so great for theme authors, who \
> don't expect the color roles to be used in an inverted fashion and feel it violates \
> their aesthetic goals. It turns out the Plasma theming system also has a \
> "Complementary" color group for use in similar cases, e.g. on the Logout screen. \
> This patch makes the delegate use the Complementary color group and swaps text vs. \
> background colors for label and background to their regular application. 
> 
> Diffs
> -----
> 
> containments/desktop/package/contents/ui/FolderItemDelegate.qml 8e34349 
> 
> Diff: https://git.reviewboard.kde.org/r/125440/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> New delegate appearance
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/28/def2ec80-b4d6-4be2-8aac-a5f8e93b842f__Screenshot_20150928_193234.png
>  
> 
> Thanks,
> 
> Eike Hein
> 
> 

--===============4996861144492273041==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125440/">https://git.reviewboard.kde.org/r/125440/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+2 \
from me if VDG is ok too</p></pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On September 28th, 2015, 5:33 p.m. UTC, Eike Hein wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Andrew Lake and Jens Reuterberg.</div>
<div>By Eike Hein.</div>

<p style="color: grey;"><i>Updated Sept. 28, 2015, 5:33 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In order to increase contrast against wallpapers, the \
item delegate for the Folder View desktop containment currently uses a rounded rect \
behind the text label. The rounded rect uses the theme's normal text color at opacity \
0.4 while the text label uses the theme's background color at opacity 1.0, to \
essentially invert the regular colors. This was originally submitted as a patch by \
the VDG.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It's been brought to my attention that this isn't so \
great for theme authors, who don't expect the color roles to be used in an inverted \
fashion and feel it violates their aesthetic goals. It turns out the Plasma theming \
system also has a "Complementary" color group for use in similar cases, e.g. on the \
Logout screen. This patch makes the delegate use the Complementary color group and \
swaps text vs. background colors for label and background to their regular \
application.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>containments/desktop/package/contents/ui/FolderItemDelegate.qml <span \
style="color: grey">(8e34349)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125440/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/28/def2ec80-b4d6-4be2-8aac-a5f8e93b842f__Screenshot_20150928_193234.png">New \
delegate appearance</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4996861144492273041==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 