'Re: Review Request 122985: [kcmkwin/deco] Hide button layout on small screen estate'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122985: [kcmkwin/deco] Hide button layout on small screen estate
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2015-09-28 13:43:43
Message-ID: 20150928134343.8863.63584 () mimi ! kde ! org
[Download RAW message or body]

--===============3631102583919617465==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122985/
-----------------------------------------------------------

(Updated Sept. 28, 2015, 3:43 p.m.)

Status
------

This change has been discarded.

Review request for kwin, Plasma, Kai Uwe Broulik, and Thomas Pfeiffer.

Repository: kwin

Description
-------

If the window is small the list of decorations might not be visible at
all giving a bad first impression on opening systemsettings and also
making the user interface difficult to use.

This change ensures that at least two decorations are visible before
we try to show the buttons view. So only if the window is large enough
the button configuration will be shown.

Otherwise a push button is displayed to explicitly show the button config
interface. This explicit show is not bound to the size of the window.

If the window gets resized in a way that there is enough place for the
button interface the view is shown autmatically and the button is hidden.

There is no button to hide the view again. This is considered not needed
as at that point a user already has seen the view and recognized that
the list of decorations can be scrolled.

Diffs
-----

  kcmkwin/kwindecoration/qml/Previews.qml eabc666432b5df04e929f1ba640a79cd99714a9d 
  kcmkwin/kwindecoration/qml/main.qml 4d8bcf8c98f238676e9128da20f4969980bf143c 

Diff: https://git.reviewboard.kde.org/r/122985/diff/

Testing
-------

File Attachments
----------------

Buttons hidden on small window
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/fe54076a-1d58-49c4-a27d-f49da4f3bb97__view-small.png
 Buttons automatically shown if window is large enough
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/29970eae-8189-47c3-b942-6aade7111956__view-large.png

Thanks,

Martin Gräßlin

--===============3631102583919617465==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122985/">https://git.reviewboard.kde.org/r/122985/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kwin, Plasma, Kai Uwe Broulik, and Thomas Pfeiffer.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Sept. 28, 2015, 3:43 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If the window is small the list of decorations might not be visible at \
all giving a bad first impression on opening systemsettings and also making the user \
interface difficult to use.

This change ensures that at least two decorations are visible before
we try to show the buttons view. So only if the window is large enough
the button configuration will be shown.

Otherwise a push button is displayed to explicitly show the button config
interface. This explicit show is not bound to the size of the window.

If the window gets resized in a way that there is enough place for the
button interface the view is shown autmatically and the button is hidden.

There is no button to hide the view again. This is considered not needed
as at that point a user already has seen the view and recognized that
the list of decorations can be scrolled.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcmkwin/kwindecoration/qml/Previews.qml <span style="color: \
grey">(eabc666432b5df04e929f1ba640a79cd99714a9d)</span></li>

 <li>kcmkwin/kwindecoration/qml/main.qml <span style="color: \
grey">(4d8bcf8c98f238676e9128da20f4969980bf143c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122985/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/fe54076a-1d58-49c4-a27d-f49da4f3bb97__view-small.png">Buttons \
hidden on small window</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/29970eae-8189-47c3-b942-6aade7111956__view-large.png">Buttons \
automatically shown if window is large enough</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3631102583919617465==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 