[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125408: kcm_keyboard: Port away from KDELibs4Support
From: "David Rosca" <nowrep () gmail ! com>
Date: 2015-09-26 20:48:26
Message-ID: 20150926204826.14939.27795 () mimi ! kde ! org
[Download RAW message or body]
--===============7924598362218519445==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 26, 2015, 8:40 p.m., Hrvoje Senjan wrote:
> > kcms/keyboard/keyboard_daemon.h, line 24
> > <https://git.reviewboard.kde.org/r/125408/diff/3/?file=408516#file408516line24>
> >
> > This still needs KDELibs4Support, whether the include is still needed, haven't \
> > checked
It's not needed, I've pushed the fix now.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125408/#review85994
-----------------------------------------------------------
On Sept. 26, 2015, 8:15 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125408/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2015, 8:15 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Port away from KDELibs4Support
>
>
> Diffs
> -----
>
> kcms/keyboard/CMakeLists.txt abf3cf8
> kcms/keyboard/bindings.h d597907
> kcms/keyboard/bindings.cpp 968721f
> kcms/keyboard/kcm_keyboard_widget.cpp c7a3589
> kcms/keyboard/keyboard_daemon.h 4d7587f
> kcms/keyboard/keyboard_daemon.cpp f2f757f
>
> Diff: https://git.reviewboard.kde.org/r/125408/diff/
>
>
> Testing
> -------
>
> Builds fine, changing global shortcut still works.
>
>
> Thanks,
>
> David Rosca
>
>
--===============7924598362218519445==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125408/">https://git.reviewboard.kde.org/r/125408/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 26th, 2015, 8:40 p.m. UTC, <b>Hrvoje \
Senjan</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125408/diff/3/?file=408516#file408516line24" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcms/keyboard/keyboard_daemon.h</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
Q_DECL_EXPORT KeyboardDaemon : public KDEDModule</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">24</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
<kdemacros.h></span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">24</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
<kdemacros.h></span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
still needs KDELibs4Support, whether the include is still needed, haven't \
checked</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It's not needed, I've pushed the fix now.</p></pre> <br />
<p>- David</p>
<br />
<p>On September 26th, 2015, 8:15 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2015, 8:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Port away from KDELibs4Support</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds fine, changing global shortcut still \
works.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/keyboard/CMakeLists.txt <span style="color: grey">(abf3cf8)</span></li>
<li>kcms/keyboard/bindings.h <span style="color: grey">(d597907)</span></li>
<li>kcms/keyboard/bindings.cpp <span style="color: grey">(968721f)</span></li>
<li>kcms/keyboard/kcm_keyboard_widget.cpp <span style="color: \
grey">(c7a3589)</span></li>
<li>kcms/keyboard/keyboard_daemon.h <span style="color: grey">(4d7587f)</span></li>
<li>kcms/keyboard/keyboard_daemon.cpp <span style="color: \
grey">(f2f757f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125408/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7924598362218519445==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic