'Re: Review Request 125117: Moved check for all mount points excluded out of widget class'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125117: Moved check for all mount points excluded out of widget class
From:       "Ovidiu-Florin BOGDAN" <ovidiu.b13 () gmail ! com>
Date:       2015-09-25 19:58:09
Message-ID: 20150925195809.14939.53466 () mimi ! kde ! org
[Download RAW message or body]

--===============3995116515822670085==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/
-----------------------------------------------------------

(Updated Sept. 25, 2015, 10:58 p.m.)

Status
------

This change has been marked as submitted.

Review request for Baloo, Plasma and Vishesh Handa.

Repository: plasma-desktop

Description
-------

And simplified the way it searches for the mount points.

Diffs
-----

  kcms/baloo/folderselectionwidget.h 6430b60 
  kcms/baloo/folderselectionwidget.cpp 3ad1764 
  kcms/baloo/kcm.h 6878e89 
  kcms/baloo/kcm.cpp d85f615 

Diff: https://git.reviewboard.kde.org/r/125117/diff/

Testing
-------

Compiled and used.

Thanks,

Ovidiu-Florin BOGDAN

--===============3995116515822670085==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125117/">https://git.reviewboard.kde.org/r/125117/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo, Plasma and Vishesh Handa.</div>
<div>By Ovidiu-Florin BOGDAN.</div>

<p style="color: grey;"><i>Updated Sept. 25, 2015, 10:58 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">And simplified the way it searches for the mount \
points.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiled and used.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/baloo/folderselectionwidget.h <span style="color: \
grey">(6430b60)</span></li>

 <li>kcms/baloo/folderselectionwidget.cpp <span style="color: \
grey">(3ad1764)</span></li>

 <li>kcms/baloo/kcm.h <span style="color: grey">(6878e89)</span></li>

 <li>kcms/baloo/kcm.cpp <span style="color: grey">(d85f615)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125117/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3995116515822670085==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 