'Re: Review Request 125328: kcm_keyboard: Remove Spare Layout option'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125328: kcm_keyboard: Remove Spare Layout option
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-09-24 21:31:11
Message-ID: 20150924213111.14939.51007 () mimi ! kde ! org
[Download RAW message or body]

--===============6033503760872852568==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Sept. 24, 2015, 9:03 p.m., David Edmundson wrote:
> > What doesn't work? I just tried spare layouts here, and it seemed to be behaving \
> > OK.
> 
> David Rosca wrote:
> Oops, you are right. It works with 3 and more layouts configured.
> But there is a bug when you have 2 or less configured layouts and when you open kcm \
> the spare layouts checkbox is enabled even when it shouldn't be. I'll change this \
> review to fix that bug instead.

Aha, found how to reproduce your bug

Add 3 layouts
enable spare layouts
click save

remove a layout
(checkbox will look unchecked)

click save

on reopen it's back to being enabled with 2 layouts

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125328/#review85894
-----------------------------------------------------------

On Sept. 20, 2015, 6:04 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125328/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2015, 6:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This option is not working (it is impossible to set from KCM - clicking on enable \
> checkbox will disable it) and also is no longer used with \
> https://git.reviewboard.kde.org/r/125327/ 
> 
> Diffs
> -----
> 
> kcms/keyboard/kcm_keyboard.ui 53974e0 
> kcms/keyboard/kcm_keyboard_widget.h 5994ea4 
> kcms/keyboard/kcm_keyboard_widget.cpp 3ae40fc 
> kcms/keyboard/kcm_view_models.cpp 093bca9 
> kcms/keyboard/keyboard_config.h aff49a7 
> kcms/keyboard/keyboard_config.cpp 1d2ee3e 
> 
> Diff: https://git.reviewboard.kde.org/r/125328/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
> 

--===============6033503760872852568==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125328/">https://git.reviewboard.kde.org/r/125328/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On September 24th, 2015, 9:03 p.m. UTC, <b>David \
Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">What doesn't work? I just tried spare layouts here, \
and it seemed to be behaving OK.</p></pre>  </blockquote>

 <p>On September 24th, 2015, 9:26 p.m. UTC, <b>David Rosca</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oops, \
you are right. It works with 3 and more layouts configured. But there is a bug when \
you have 2 or less configured layouts and when you open kcm the spare layouts \
checkbox is enabled even when it shouldn't be. I'll change this review to fix that \
bug instead.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Aha, \
found how to reproduce your bug</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Add 3 layouts enable \
spare layouts click save</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">remove a layout (checkbox will look unchecked)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">click save</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">on reopen it's back to \
being enabled with 2 layouts</p></pre> <br />

<p>- David</p>

<br />
<p>On September 20th, 2015, 6:04 p.m. UTC, David Rosca wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated Sept. 20, 2015, 6:04 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This option is not working (it is impossible to set \
from KCM - clicking on enable checkbox will disable it) and also is no longer used \
with https://git.reviewboard.kde.org/r/125327/</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/keyboard/kcm_keyboard.ui <span style="color: grey">(53974e0)</span></li>

 <li>kcms/keyboard/kcm_keyboard_widget.h <span style="color: \
grey">(5994ea4)</span></li>

 <li>kcms/keyboard/kcm_keyboard_widget.cpp <span style="color: \
grey">(3ae40fc)</span></li>

 <li>kcms/keyboard/kcm_view_models.cpp <span style="color: \
grey">(093bca9)</span></li>

 <li>kcms/keyboard/keyboard_config.h <span style="color: grey">(aff49a7)</span></li>

 <li>kcms/keyboard/keyboard_config.cpp <span style="color: \
grey">(1d2ee3e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125328/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6033503760872852568==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 