'Re: Review Request 125349: use a RowLayout for ToolbarLayout'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-panel-devel
Subject: Re: Review Request 125349: use a RowLayout for ToolbarLayout
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-09-23 10:33:44
Message-ID: 20150923103344.28417.20571 () mimi ! kde ! org
[Download RAW message or body]

--===============6711746785232268999==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Sept. 22, 2015, 1:22 p.m., David Edmundson wrote:
> > src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml, line 48
> > <https://git.reviewboard.kde.org/r/125349/diff/1/?file=405034#file405034line48>
> > 
> > So to make sure I'm clear we want to get
> > 
> > child[0]
> > spacer1
> > child[1.....n-1]
> > spacer2
> > child[n]
> 
> Marco Martin wrote:
> yeah
> 
> David Edmundson wrote:
> That seems rather random. Why?
> I predict we'll just see devs work round this by wrapping things in items or adding \
> blank items all over the place. 
> Marco Martin wrote:
> ...or just use RowLayout directly, that's perfectly fine
> that's to look like the discussions we done at Randa on apps look.
> now, i could also do this in higher level components that i'll need to do anyways \
> and the first/last buttons would have some semantic meaning (opening/closing the \
> left and right menu) so it may make sense to having only centered buttons as \
> children and properties for the left and right one.

> ...or just use RowLayout directly, 

Didn't think of that. Good point.

Though at the least it needs a line in the documentation so it doesn't appear \
unexpected.

I prefer higher level semanatic meaning.
if it said "property Item primaryControl" 

 - it'd be more intuitive to use properly
 - we can restyle it in the future
 - it'll be easier to leave blank
+ then we could maybe then just make a default property that alias' into an inner \
layout and not have that function. 

One thing to note, your middle actions currently aren't centered relative to the \
toolbar but to the first and last children. i.e if your last child is giant, and the \
first is tiny the middle items will be slightly to the left of the middle of the \
toolbar

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125349/#review85751
-----------------------------------------------------------

On Sept. 22, 2015, 2:35 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125349/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 2:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> more reliable.
> also put the first and last buttons at the extremes, the others in the middle as \
> briefly discussed with the VDG in Randa 
> 
> Diffs
> -----
> 
> src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml 4206bed 
> 
> Diff: https://git.reviewboard.kde.org/r/125349/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
> 

--===============6711746785232268999==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125349/">https://git.reviewboard.kde.org/r/125349/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On September 22nd, 2015, 1:22 p.m. UTC, <b>David \
Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/125349/diff/1/?file=405034#file405034line48" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">39</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="nx">QtObject</span> <span class="p">{</span></pre></td>  <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">48</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="nx">QtObject</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So to \
make sure I'm clear we want to get</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">child[0] spacer1
child[1.....n-1]
spacer2
child[n]</p></pre>
 </blockquote>

 <p>On September 22nd, 2015, 1:48 p.m. UTC, <b>Marco Martin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">yeah</p></pre>  </blockquote>

 <p>On September 23rd, 2015, 9:14 a.m. UTC, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That \
seems rather random. Why? I predict we'll just see devs work round this by wrapping \
things in items or adding blank items all over the place.</p></pre>  </blockquote>

 <p>On September 23rd, 2015, 9:36 a.m. UTC, <b>Marco Martin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">...or \
just use RowLayout directly, that's perfectly fine that's to look like the \
discussions we done at Randa on apps look. now, i could also do this in higher level \
components that i'll need to do anyways and the first/last buttons would have some \
semantic meaning (opening/closing the left and right menu) so it may make sense to \
having only centered buttons as children and properties for the left and right \
one.</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> ...or just use RowLayout directly, </blockquote>
Didn't think of that. Good point. Though at the least it needs a line in the documentation so it doesn't \
appear unexpected. I prefer higher level semanatic \
meaning. if it said "property Item primaryControl" 
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">it'd be more intuitive to use \
properly</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">we can restyle it in the future</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">it'll be easier to leave blank</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">then we could maybe then \
just make a default property that alias' into an inner layout and not have that \
function. </li> </ul>
One thing to note, your middle actions currently \
aren't centered relative to the toolbar but to the first and last children. i.e if \
your last child is giant, and the first is tiny the middle items will be slightly to \
the left of the middle of the toolbar</pre>

<p>- David</p>

<br />
<p>On September 22nd, 2015, 2:35 p.m. UTC, Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Sept. 22, 2015, 2:35 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">more reliable. also put the first and last buttons at \
the extremes, the others in the middle as briefly discussed with the VDG in \
Randa</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml <span \
style="color: grey">(4206bed)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125349/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6711746785232268999==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 