[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size
From:       "Yoann Laissus" <yoann.laissus () gmail ! com>
Date:       2015-09-13 17:25:09
Message-ID: 20150913172509.3546.97337 () mimi ! kde ! org
[Download RAW message or body]

--===============5353900146987702547==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123818/
-----------------------------------------------------------

(Updated Sept. 13, 2015, 5:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 9b474a4ab01c3268048e29c336cf7b3fe9a83a47 by Yoann Laissus to \
branch master.


Repository: plasma-workspace


Description
-------

Currently, the size of devices is retrieved with solid.
Unfortunately, it doesn't work for network shares. Only the "StorageVolume" type has \
the "size" option.

KDiskFreeSpaceInfo supports every mounted device, not matter its type.


Diffs
-----

  applets/devicenotifier/package/contents/ui/FullRepresentation.qml \
0a5b035d1afac368faf85f6dd0ff41bab4812562   \
dataengines/soliddevice/soliddeviceengine.h 85bdc68d4d7a9a8704d8ff1dcd29355c784ed435  \
dataengines/soliddevice/soliddeviceengine.cpp \
94819c7405a3eb4b0ef679a55de2de20bd05fdb2   \
dataengines/soliddevice/soliddeviceservice.cpp \
f2f96ef4d63f41e3e2ea9bf31297adfcdf151a97 

Diff: https://git.reviewboard.kde.org/r/123818/diff/


Testing
-------

Tested with local disks, USB devices, NFS shares


Thanks,

Yoann Laissus


--===============5353900146987702547==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123818/">https://git.reviewboard.kde.org/r/123818/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>


<p style="color: grey;"><i>Updated Sept. 13, 2015, 5:25 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 9b474a4ab01c3268048e29c336cf7b3fe9a83a47 by Yoann \
Laissus to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently, the size of devices is retrieved with \
solid. Unfortunately, it doesn't work for network shares. Only the "StorageVolume" \
type has the "size" option.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">KDiskFreeSpaceInfo supports every \
mounted device, not matter its type.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with local disks, USB devices, NFS \
shares</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/devicenotifier/package/contents/ui/FullRepresentation.qml <span \
style="color: grey">(0a5b035d1afac368faf85f6dd0ff41bab4812562)</span></li>

 <li>dataengines/soliddevice/soliddeviceengine.h <span style="color: \
grey">(85bdc68d4d7a9a8704d8ff1dcd29355c784ed435)</span></li>

 <li>dataengines/soliddevice/soliddeviceengine.cpp <span style="color: \
grey">(94819c7405a3eb4b0ef679a55de2de20bd05fdb2)</span></li>

 <li>dataengines/soliddevice/soliddeviceservice.cpp <span style="color: \
grey">(f2f96ef4d63f41e3e2ea9bf31297adfcdf151a97)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123818/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============5353900146987702547==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic