'Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6
From:       "Takahiro Hashimoto" <kenya888 () gmail ! com>
Date:       2015-09-11 13:01:41
Message-ID: 20150911130141.24667.30903 () mimi ! kde ! org
[Download RAW message or body]

--===============7159031247521971728==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124877/
-----------------------------------------------------------

(Updated 9月 11, 2015, 10:01 p.m.)

Review request for Plasma.

Changes
-------

Update test result.

Bugs: 351609
    https://bugs.kde.org/show_bug.cgi?id=351609

Repository: plasma-workspace

Description
-------

Building Plasma5 with Qt 5.6 branch, kstartupconfig5/kdostartupconfig5 generates \
corrupted files.

$HOME/.config/startupconfigfiles
$HOME/.config/startupconfig

Diffs
-----

  startkde/kstartupconfig/kdostartupconfig.cpp 3944c06 

Diff: https://git.reviewboard.kde.org/r/124877/diff/

Testing (updated)
-------

works for me. 

1. execute kstartupconfig5
2. check if both files are not corrupted.

Updated: rebased with latest and tested with Revision 2 the same test. OK.

Thanks,

Takahiro Hashimoto

--===============7159031247521971728==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124877/">https://git.reviewboard.kde.org/r/124877/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Takahiro Hashimoto.</div>

<p style="color: grey;"><i>Updated 9月 11, 2015, 10:01 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Update test result.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=351609">351609</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Building Plasma5 with Qt 5.6 branch, kstartupconfig5/kdostartupconfig5 \
generates corrupted files.

$HOME/.config/startupconfigfiles
$HOME/.config/startupconfig</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">works for me. </p> <ol style="padding: \
0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">execute kstartupconfig5</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">check \
if both files are not corrupted.</li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Updated: rebased with latest and tested with Revision \
2 the same test. OK.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>startkde/kstartupconfig/kdostartupconfig.cpp <span style="color: \
grey">(3944c06)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124877/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7159031247521971728==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 