[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6
From: "Takahiro Hashimoto" <kenya888 () gmail ! com>
Date: 2015-09-02 15:19:02
Message-ID: 20150902151902.10622.54922 () mimi ! kde ! org
[Download RAW message or body]
--===============3977359602549724385==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On 9月 2, 2015, 11:14 p.m., Alex Richardson wrote:
> > startkde/kstartupconfig/kdostartupconfig.cpp, line 86
> > <https://git.reviewboard.kde.org/r/124877/diff/1/?file=397209#file397209line86>
> >
> > `QByteArray buf = keys.readLine()`
> >
> > I don't see the point of preallocation 1024 bytes (I doubt this does any good \
> > anyway) and using the less safe C-style API
>
> Alex Richardson wrote:
> Or even better just `QString line = QString::fromLocal8Bit(keys.readLine());`
Yay I agree with you. I'd like to update patch.
- Takahiro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124877/#review84764
-----------------------------------------------------------
On 9月 3, 2015, 12:18 a.m., Takahiro Hashimoto wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124877/
> -----------------------------------------------------------
>
> (Updated 9月 3, 2015, 12:18 a.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 351609
> https://bugs.kde.org/show_bug.cgi?id=351609
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Building Plasma5 with Qt 5.6 branch, kstartupconfig5/kdostartupconfig5 generates \
> corrupted files.
> $HOME/.config/startupconfigfiles
> $HOME/.config/startupconfig
>
>
> Diffs
> -----
>
> startkde/kstartupconfig/kdostartupconfig.cpp 3944c06
>
> Diff: https://git.reviewboard.kde.org/r/124877/diff/
>
>
> Testing
> -------
>
> works for me.
>
> 1. execute kstartupconfig5
> 2. check if both files are not corrupted.
>
>
> Thanks,
>
> Takahiro Hashimoto
>
>
--===============3977359602549724385==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124877/">https://git.reviewboard.kde.org/r/124877/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On 9月 2nd, 2015, 11:14 p.m. JST, <b>Alex \
Richardson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124877/diff/1/?file=397209#file397209line86" \
style="color: black; font-weight: bold; text-decoration: \
underline;">startkde/kstartupconfig/kdostartupconfig.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main( int argc, char **argv )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">86</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span> \
<span class="n">QString</span> <span class="n">line</span><span \
class="p">;</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">86</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="tb"> </span> <span \
class="n">QString</span> <span class="n">line</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">QByteArray buf = keys.readLine()</code></p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I don't see the point of preallocation 1024 bytes (I doubt this does any \
good anyway) and using the less safe C-style API</p></pre> </blockquote>
<p>On 9月 2nd, 2015, 11:15 p.m. JST, <b>Alex Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Or \
even better just <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">QString line = \
QString::fromLocal8Bit(keys.readLine());</code></p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Yay I agree with you. I'd like to update patch.</p></pre> <br />
<p>- Takahiro</p>
<br />
<p>On 9月 3rd, 2015, 12:18 a.m. JST, Takahiro Hashimoto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Takahiro Hashimoto.</div>
<p style="color: grey;"><i>Updated 9月 3, 2015, 12:18 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=351609">351609</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Building Plasma5 with Qt 5.6 branch, kstartupconfig5/kdostartupconfig5 \
generates corrupted files.
$HOME/.config/startupconfigfiles
$HOME/.config/startupconfig</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">works for me. </p> <ol style="padding: \
0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">execute kstartupconfig5</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">check \
if both files are not corrupted.</li> </ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startkde/kstartupconfig/kdostartupconfig.cpp <span style="color: \
grey">(3944c06)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124877/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3977359602549724385==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic