[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121915: Add lidClosedChanged signal to org.kde.Solid.PowerManagement
From: Daniel_Vrátil <dvratil () kde ! org>
Date: 2015-09-02 11:38:35
Message-ID: 20150902113835.10622.95564 () mimi ! kde ! org
[Download RAW message or body]
--===============7240149010403267983==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121915/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 11:38 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Solid.
Changes
-------
Submitted with commit b5a1e1bec3052460ff8c87764a065cc61cdeba47 by Dan Vrátil to \
branch master.
Repository: powerdevil
Description
-------
There's no way to detect when lid has been closed other than listening to `changed` \
signal org.freedesktop.UPower and then polling the Powerdevil for new values. This \
patch adds a new signal to the PowerDevil interface to notify about the change and \
provide new value right away. Makes it much easier to use.
Diffs
-----
daemon/org.kde.Solid.PowerManagement.xml 53f77e5
daemon/powerdevilbackendinterface.h 702b66b
daemon/powerdevilbackendinterface.cpp 6dd8c71
daemon/powerdevilcore.h e255703
daemon/powerdevilcore.cpp d51ab19
Diff: https://git.reviewboard.kde.org/r/121915/diff/
Testing
-------
Tested with qdbus-monitor, signal is emitted when laptop lid is closed/opened.
Thanks,
Daniel Vrátil
--===============7240149010403267983==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121915/">https://git.reviewboard.kde.org/r/121915/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Solid.</div>
<div>By Daniel Vrátil.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2015, 11:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit b5a1e1bec3052460ff8c87764a065cc61cdeba47 by Dan \
Vrátil to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There's no way to detect when lid has been closed \
other than listening to <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">changed</code> signal \
org.freedesktop.UPower and then polling the Powerdevil for new values. This patch \
adds a new signal to the PowerDevil interface to notify about the change and provide \
new value right away. Makes it much easier to use.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with qdbus-monitor, signal is emitted when \
laptop lid is closed/opened.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>daemon/org.kde.Solid.PowerManagement.xml <span style="color: \
grey">(53f77e5)</span></li>
<li>daemon/powerdevilbackendinterface.h <span style="color: \
grey">(702b66b)</span></li>
<li>daemon/powerdevilbackendinterface.cpp <span style="color: \
grey">(6dd8c71)</span></li>
<li>daemon/powerdevilcore.h <span style="color: grey">(e255703)</span></li>
<li>daemon/powerdevilcore.cpp <span style="color: grey">(d51ab19)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121915/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7240149010403267983==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic