'Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet
From:       Daniel_Vrátil <dvratil () kde ! org>
Date:       2015-09-02 11:27:47
Message-ID: 20150902112747.10622.99697 () mimi ! kde ! org
[Download RAW message or body]

--===============7445888718597613491==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110476/
-----------------------------------------------------------

(Updated Sept. 2, 2015, 1:27 p.m.)

Status
------

This change has been discarded.

Review request for Plasma.

Repository: kde-workspace

Description
-------

Call KNotification::close() when user clicks the 'X' button in the Notifications \
applet.

This prevents leaking persistent notifications and allows applications to depend on \
KNotification::closed() signal.

Diffs
-----

  plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
64d9298   plasma/generic/applets/notifications/contents/ui/Notifications.qml c5be0a3 
  plasma/generic/dataengines/notifications/notificationaction.cpp 397073e 
  plasma/generic/dataengines/notifications/notificationsengine.cpp 25fccbb 

Diff: https://git.reviewboard.kde.org/r/110476/diff/

Testing
-------

Thanks,

Daniel Vrátil

--===============7445888718597613491==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/110476/">https://git.reviewboard.kde.org/r/110476/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Daniel Vrátil.</div>

<p style="color: grey;"><i>Updated Sept. 2, 2015, 1:27 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Call KNotification::close() when user clicks the &#39;X&#39; button in \
the Notifications applet.

This prevents leaking persistent notifications and allows applications to depend on \
KNotification::closed() signal.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
<span style="color: grey">(64d9298)</span></li>

 <li>plasma/generic/applets/notifications/contents/ui/Notifications.qml <span \
style="color: grey">(c5be0a3)</span></li>

 <li>plasma/generic/dataengines/notifications/notificationaction.cpp <span \
style="color: grey">(397073e)</span></li>

 <li>plasma/generic/dataengines/notifications/notificationsengine.cpp <span \
style="color: grey">(25fccbb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/110476/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7445888718597613491==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 