[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and n
From: "Hanspeter Niederstrasser" <niederstrasser () gmail ! com>
Date: 2015-08-31 21:10:39
Message-ID: 20150831211039.10622.6399 () mimi ! kde ! org
[Download RAW message or body]
--===============2582244697080870072==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124892/
-----------------------------------------------------------
(Updated Aug. 31, 2015, 9:10 p.m.)
Status
------
This change has been discarded.
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, Plasma, and Harald \
Sitter.
Bugs: 342962
https://bugs.kde.org/show_bug.cgi?id=342962
Repository: kdeclarative
Description
-------
The kdeclarative plugins (draganddropplugin, kcoreaddonsplugin, kio, \
kquickcontrolsprivateplugin, and kquickcontrolsaddonsplugin) are being built as shared \
libraries. They should be built as bundles (MODULE) in the CMakeLists.txt file.
When built as SHARED as in the current code, libdraganddropplugin.dylib gets installed to \
$PREFIX/share/qt5/qml/org/kde/draganddrop, but is given an OS X install_name of \
$PREFIX/lib/libdraganddropplugin.dylib. This mismatch can cause problems. It is also given a \
compatibility_version of 0.0.0.
Diffs
-----
src/qmlcontrols/draganddrop/CMakeLists.txt e8127e4
src/qmlcontrols/kcoreaddons/CMakeLists.txt 3f77f2d
src/qmlcontrols/kioplugin/CMakeLists.txt 7b258e0
src/qmlcontrols/kquickcontrols/private/CMakeLists.txt da355c1
src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1
Diff: https://git.reviewboard.kde.org/r/124892/diff/
Testing
-------
Since the plugin is not supposed to be a linkable library, it should be built as MODULE in \
CMakeLists.txt. The physical install location remains the same and plugins don't have \
install_names. This corrects the install_name/install location mismatch. The change should not \
have any effect on non-OS X systems.
Thanks,
Hanspeter Niederstrasser
--===============2582244697080870072==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124892/">https://git.reviewboard.kde.org/r/124892/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, Plasma, and \
Harald Sitter.</div> <div>By Hanspeter Niederstrasser.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2015, 9:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=342962">342962</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
kdeclarative plugins (draganddropplugin, kcoreaddonsplugin, kio, kquickcontrolsprivateplugin, \
and kquickcontrolsaddonsplugin) are being built as shared libraries. They should be built as \
bundles (MODULE) in the CMakeLists.txt file.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">When built as SHARED as in the \
current code, libdraganddropplugin.dylib gets installed to \
$PREFIX/share/qt5/qml/org/kde/draganddrop, but is given an OS X install_name of \
$PREFIX/lib/libdraganddropplugin.dylib. This mismatch can cause problems. It is also given a \
compatibility_version of 0.0.0.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since the \
plugin is not supposed to be a linkable library, it should be built as MODULE in \
CMakeLists.txt. The physical install location remains the same and plugins don't have \
install_names. This corrects the install_name/install location mismatch. The change should not \
have any effect on non-OS X systems.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/qmlcontrols/draganddrop/CMakeLists.txt <span style="color: grey">(e8127e4)</span></li>
<li>src/qmlcontrols/kcoreaddons/CMakeLists.txt <span style="color: grey">(3f77f2d)</span></li>
<li>src/qmlcontrols/kioplugin/CMakeLists.txt <span style="color: grey">(7b258e0)</span></li>
<li>src/qmlcontrols/kquickcontrols/private/CMakeLists.txt <span style="color: \
grey">(da355c1)</span></li>
<li>src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt <span style="color: \
grey">(5b711e1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124892/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2582244697080870072==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic