[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120564: Write default file manager into mimeapps.list in XDG_CONFIG_HOME
From:       "Luc Menut" <lmenut () free ! fr>
Date:       2015-08-31 20:56:22
Message-ID: 20150831205622.10622.33155 () mimi ! kde ! org
[Download RAW message or body]

--===============1839987684286720543==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120564/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 8:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Faure.


Changes
-------

Submitted with commit ebd8e972a77fe701586ab638ede3184eb4eece19 by David Edmundson on \
behalf of Luc Menut to branch Plasma/5.4.


Repository: plasma-desktop


Description
-------

Write the default file manager into mimeapps.list (inode/directory) in \
XDG_CONFIG_HOME, as per mime-apps spec \
http://standards.freedesktop.org/mime-apps-spec/mime-apps-spec-1.0.1.html#file

keditfiletype (kde-cli-tools) already reads/writes mimeapps.list in XDG_CONFIG_HOME \
since http://quickgit.kde.org/?p=kde-cli-tools.git&a=commit&h=e0d3bbdd0f68c39126a3c81bc373b53947d402f1


regards,

Luc Menut - Mageia

PS: I don't have write access to kde git, so could you commit the change if the patch \
looks fine. Thanks.


Diffs
-----

  kcms/componentchooser/componentchooserfilemanager.cpp b23bfa0 

Diff: https://git.reviewboard.kde.org/r/120564/diff/


Testing
-------


Thanks,

Luc Menut


--===============1839987684286720543==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120564/">https://git.reviewboard.kde.org/r/120564/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and David Faure.</div>
<div>By Luc Menut.</div>


<p style="color: grey;"><i>Updated Aug. 31, 2015, 8:56 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit ebd8e972a77fe701586ab638ede3184eb4eece19 by David \
Edmundson on behalf of Luc Menut to branch Plasma/5.4.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Write the default file manager into mimeapps.list \
(inode/directory) in XDG_CONFIG_HOME, as per mime-apps spec \
http://standards.freedesktop.org/mime-apps-spec/mime-apps-spec-1.0.1.html#file</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">keditfiletype (kde-cli-tools) already reads/writes mimeapps.list in \
XDG_CONFIG_HOME since \
http://quickgit.kde.org/?p=kde-cli-tools.git&amp;a=commit&amp;h=e0d3bbdd0f68c39126a3c81bc373b53947d402f1</p>
 <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">regards,</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Luc Menut - Mageia</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">PS: I don't have write access to kde git, so could you \
commit the change if the patch looks fine. Thanks.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/componentchooser/componentchooserfilemanager.cpp <span style="color: \
grey">(b23bfa0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120564/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============1839987684286720543==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic