--===============7074463571834172308== Content-Type: multipart/alternative; boundary="===============4453030215031672373==" --===============4453030215031672373== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123818/#review84670 ----------------------------------------------------------- Yoann, do you have commit access? - David Edmundson On May 16, 2015, 6:44 p.m., Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123818/ > ----------------------------------------------------------- > > (Updated May 16, 2015, 6:44 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Currently, the size of devices is retrieved with solid. > Unfortunately, it doesn't work for network shares. Only the "StorageVolume" type has the "size" option. > > KDiskFreeSpaceInfo supports every mounted device, not matter its type. > > > Diffs > ----- > > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 0a5b035d1afac368faf85f6dd0ff41bab4812562 > dataengines/soliddevice/soliddeviceengine.h 85bdc68d4d7a9a8704d8ff1dcd29355c784ed435 > dataengines/soliddevice/soliddeviceengine.cpp 94819c7405a3eb4b0ef679a55de2de20bd05fdb2 > dataengines/soliddevice/soliddeviceservice.cpp f2f96ef4d63f41e3e2ea9bf31297adfcdf151a97 > > Diff: https://git.reviewboard.kde.org/r/123818/diff/ > > > Testing > ------- > > Tested with local disks, USB devices, NFS shares > > > Thanks, > > Yoann Laissus > > --===============4453030215031672373== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123818/

Yoann, do you have commit access?

- David Edmundson

On May 16th, 2015, 6:44 p.m. UTC, Yoann Laissus wrote:

Review request for Plasma.

By Yoann Laissus.

Updated May 16, 2015, 6:44 p.m.

Repository: plasma-workspace

Description

Currently, the size of devices is retrieved with solid. Unfortunately, it doesn't work for network shares. Only the "StorageVolume" type has the "size" option.

KDiskFreeSpaceInfo supports every mounted device, not matter its type.

Testing

Tested with local disks, USB devices, NFS shares

Diffs

applets/devicenotifier/package/contents/ui/FullRepresentation.qml (0a5b035d1afac368faf85f6dd0ff41bab4812562)
dataengines/soliddevice/soliddeviceengine.h (85bdc68d4d7a9a8704d8ff1dcd29355c784ed435)
dataengines/soliddevice/soliddeviceengine.cpp (94819c7405a3eb4b0ef679a55de2de20bd05fdb2)
dataengines/soliddevice/soliddeviceservice.cpp (f2f96ef4d63f41e3e2ea9bf31297adfcdf151a97)

--===============4453030215031672373==-- --===============7074463571834172308== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7074463571834172308==--