--===============8461418543777748846== Content-Type: multipart/alternative; boundary="===============5770504849149646248==" --===============5770504849149646248== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124933/ ----------------------------------------------------------- (Updated Aug. 31, 2015, 12:16 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit e2df9af6e2df4ba1c07dc40d43ecd591584db498 by Martin Gräßlin to branch master. Repository: plasma-workspace Description ------- This fixes type errors shown on startup: TypeError: Cannot read property 'showPassword' of undefined TypeError: Cannot read property 'ButtonLabel' of undefined REVIEW: 124931 [screenlocker] Try to load faster by using more loaders All UI is put into a loader to get the actual lock screen loaded faster. This gets the creation of two views down to about < 600 msec from before around 1.8 sec. The initial startup time is extremely important to ensure the screen is properly locked when going to suspend. Diffs ----- ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c lookandfeel/contents/lockscreen/ChangeSession.qml PRE-CREATION lookandfeel/contents/lockscreen/LockOsd.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a001efc2ffab2d78388e3a619d0de93f1758 lookandfeel/contents/lockscreen/MainBlock.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124933/diff/ Testing ------- the OSD is not anchored correctly any more. Thanks, Martin Gräßlin --===============5770504849149646248== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124933/

This change has been marked as submitted.

Review request for Plasma.
By Martin Gräßlin.

Updated Aug. 31, 2015, 12:16 p.m.

Changes

Submitted with commit e2df9af6e2df4ba1c07dc40d43ecd591584db498 by Martin Gräßlin to branch master.
Repository: plasma-workspace

Description 

This fixes type errors shown on startup:
TypeError: Cannot read property 'showPassword' of undefined
TypeError: Cannot read property 'ButtonLabel' of undefined

REVIEW: 124931

[screenlocker] Try to load faster by using more loaders

All UI is put into a loader to get the actual lock screen loaded faster.
This gets the creation of two views down to about < 600 msec from before
around 1.8 sec. The initial startup time is extremely important to ensure
the screen is properly locked when going to suspend.

Testing 

the OSD is not anchored correctly any more.

Diffs

  • ksmserver/screenlocker/greeter/greeterapp.cpp (b500ba44c2b483d7372ca46840152c90ef5f798c)
  • lookandfeel/contents/lockscreen/ChangeSession.qml (PRE-CREATION)
  • lookandfeel/contents/lockscreen/LockOsd.qml (PRE-CREATION)
  • lookandfeel/contents/lockscreen/LockScreen.qml (4ce9a001efc2ffab2d78388e3a619d0de93f1758)
  • lookandfeel/contents/lockscreen/MainBlock.qml (PRE-CREATION)

View Diff
--===============5770504849149646248==-- --===============8461418543777748846== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============8461418543777748846==--