--===============5127681259453443767== Content-Type: multipart/alternative; boundary="===============6973305521931030262==" --===============6973305521931030262== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124929/ ----------------------------------------------------------- (Updated Aug. 31, 2015, 12:16 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and David Edmundson. Changes ------- Submitted with commit a47d95473a452e35ac891cd64c92f857e3023a5e by Martin Gräßlin to branch master. Repository: plasma-workspace Description ------- It set to arrow cursor which is the default anyway. [screenlocker] Drop setting event mask on the background window We don't need it as we get keyboard and pointer events anyway (grab), exposure is set by Qt anyway and for everything else we have substructure redirect on the root window. Setting the background pixel is also no longer needed: we render a black, non-translucent window. [screenlocker] Rename LockWindow to X11Locker The LockWindow is no longer a window, but it's the actual locker for X11. Diffs ----- ksmserver/screenlocker/autotests/lockwindowtest.cpp 7d8fe542b98ab19cf04554e179e63e238d34e09d ksmserver/screenlocker/ksldapp.h 27c25df3bca7b30d78b1e4de34c437aa7ff33f59 ksmserver/screenlocker/ksldapp.cpp 83527045890eac4e2cbd84767db10da4279cc5b5 ksmserver/screenlocker/lockwindow.h dffaa729081cf3c6cff507f0a481e30666e2ddbc ksmserver/screenlocker/lockwindow.cpp 41d54b3c5ffe67de4a09676e589effc4c564e470 Diff: https://git.reviewboard.kde.org/r/124929/diff/ Testing ------- Thanks, Martin Gräßlin --===============6973305521931030262== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124929/

This change has been marked as submitted.

Review request for Plasma and David Edmundson.
By Martin Gräßlin.

Updated Aug. 31, 2015, 12:16 p.m.

Changes

Submitted with commit a47d95473a452e35ac891cd64c92f857e3023a5e by Martin Gräßlin to branch master.
Repository: plasma-workspace

Description 

It set to arrow cursor which is the default anyway.

[screenlocker] Drop setting event mask on the background window

We don't need it as we get keyboard and pointer events anyway (grab),
exposure is set by Qt anyway and for everything else we have
substructure redirect on the root window.

Setting the background pixel is also no longer needed: we render a
black, non-translucent window.

[screenlocker] Rename LockWindow to X11Locker

The LockWindow is no longer a window, but it's the actual locker for
X11.

Diffs

  • ksmserver/screenlocker/autotests/lockwindowtest.cpp (7d8fe542b98ab19cf04554e179e63e238d34e09d)
  • ksmserver/screenlocker/ksldapp.h (27c25df3bca7b30d78b1e4de34c437aa7ff33f59)
  • ksmserver/screenlocker/ksldapp.cpp (83527045890eac4e2cbd84767db10da4279cc5b5)
  • ksmserver/screenlocker/lockwindow.h (dffaa729081cf3c6cff507f0a481e30666e2ddbc)
  • ksmserver/screenlocker/lockwindow.cpp (41d54b3c5ffe67de4a09676e589effc4c564e470)

View Diff
--===============6973305521931030262==-- --===============5127681259453443767== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5127681259453443767==--