From kde-panel-devel Mon Aug 31 12:16:05 2015 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Mon, 31 Aug 2015 12:16:05 +0000 To: kde-panel-devel Subject: Re: Review Request 124917: [screenlocker] Start grace time when the greeter is shown Message-Id: <20150831121605.10622.53220 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144102339325770 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3931504470133055446==" --===============3931504470133055446== Content-Type: multipart/alternative; boundary="===============8920081075658074145==" --===============8920081075658074145== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124917/ ----------------------------------------------------------- (Updated Aug. 31, 2015, 12:16 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit 46750b8c958916f2d865bac29f329959b3d6c7e8 by Martin Gräßlin to branch master. Repository: plasma-workspace Description ------- So far the grace time started with the idle timeout. Given that our greeter takes a few seconds to start it rendered a short grace time useless as it was quite likely that the grace time already ended when the first visible feedback was shown to the user. Now the grace time starts when the greeter is actually shown. Diffs ----- ksmserver/screenlocker/ksldapp.cpp d0636b8785101cb9896cea6399952dac0e4cd227 Diff: https://git.reviewboard.kde.org/r/124917/diff/ Testing ------- * grace time of 5 sec: waited for the lock screen to show, counted to 4, moved mouse -> unlocked * waited till the lock screen was shown and a few minutes more, moved mouse -> no unlock Thanks, Martin Gräßlin --===============8920081075658074145== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124917/

This change has been marked as submitted.

Review request for Plasma.
By Martin Gräßlin.

Updated Aug. 31, 2015, 12:16 p.m.

Changes

Submitted with commit 46750b8c958916f2d865bac29f329959b3d6c7e8 by Martin Gräßlin to branch master.
Repository: plasma-workspace

Description 

So far the grace time started with the idle timeout. Given that our
greeter takes a few seconds to start it rendered a short grace time
useless as it was quite likely that the grace time already ended when
the first visible feedback was shown to the user.

Now the grace time starts when the greeter is actually shown.

Testing 

    

  • grace time of 5 sec: waited for the lock screen to show, counted to 4, moved mouse -> unlocked
    • 

  • waited till the lock screen was shown and a few minutes more, moved mouse -> no unlock
    •

Diffs

  • ksmserver/screenlocker/ksldapp.cpp (d0636b8785101cb9896cea6399952dac0e4cd227)

View Diff
--===============8920081075658074145==-- --===============3931504470133055446== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============3931504470133055446==--