--===============1844173838208187036== Content-Type: multipart/alternative; boundary="===============3529554414718752979==" --===============3529554414718752979== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 31, 2015, 1:41 p.m., Marco Martin wrote: > > Ship It! Is this still needed ? Comic works in Plasma 5 now. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120563/#review84629 ----------------------------------------------------------- On Oct. 12, 2014, 7:05 p.m., Andrei Amuraritei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120563/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2014, 7:05 p.m.) > > > Review request for Plasma, Bhushan Shah, David Edmundson, Marco Martin, and Martin Klapetek. > > > Repository: plasma-framework > > > Description > ------- > > This adds support for installing .comic type packages with plasmapkg2. This comes to help the comic dataengine port to frameworks, and permits the user to install .comic packages. > > > Diffs > ----- > > src/plasmapkg/plasmapkg.cpp 7d55d0f > > Diff: https://git.reviewboard.kde.org/r/120563/diff/ > > > Testing > ------- > > Apply patch, rebuild plasma-framework, compile ok. Then install a .comic package from kde-files.org Plasma/Comics with plasmapkg2 -t comic -i ~/Downloads/garfield.comic. > > Expected results: > > Install method: > plasmapkg2 -t comic -i ~/Downloads/92037-garfield.comic > > pluginname: "garfield" > -- Copying "/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop" > Copying metadata went ok. > Successfully installed /home/developer/Downloads/92037-garfield.comic > > Remove method: > plasmapkg2 -t comic -r ~/Downloads/92037-garfield.comic > > Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5" > Successfully uninstalled /home/developer/Downloads/92037-garfield.comic > > Upgrade method: > plasmapkg2 -t comic -u ~/Downloads/92037-garfield.comic > > Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5" > Upgrading package from file: /home/developer/Downloads/92037-garfield.comic > pluginname: "garfield" > -- Copying "/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop" > Copying metadata went ok. > Successfully upgraded /home/developer/Downloads/92037-garfield.comic > > > Thanks, > > Andrei Amuraritei > > --===============3529554414718752979== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120563/ |
On August 31st, 2015, 1:41 p.m. EEST, Marco Martin wrote:
Ship It!
Is this still needed ? Comic works in Plasma 5 now.
- Andrei
On Octombrie 12th, 2014, 7:05 p.m. EEST, Andrei Amuraritei wrote:
Review request for Plasma, Bhushan Shah, David Edmundson, Marco Martin, and Martin Klapetek.
By Andrei Amuraritei.
Updated Oct. 12, 2014, 7:05 p.m.
Repository:
plasma-framework
Description
Testing
Diffs
|