From kde-panel-devel Mon Aug 31 11:02:46 2015 From: "Greg T" Date: Mon, 31 Aug 2015 11:02:46 +0000 To: kde-panel-devel Subject: Re: Review Request 105779: plasma calendar - order events and todos by start date Message-Id: <20150831110246.10622.55223 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144101897824428 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4583285740583885808==" --===============4583285740583885808== Content-Type: multipart/alternative; boundary="===============2702261531340962691==" --===============2702261531340962691== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105779/ ----------------------------------------------------------- (Updated Aug. 31, 2015, 11:02 a.m.) Status ------ This change has been discarded. Review request for Plasma. Bugs: 291422 http://bugs.kde.org/show_bug.cgi?id=291422 Repository: kde-workspace Description ------- QHash::values returns a list of items in arbitrary order. So I'm using a QMap to sort them by start time. Diffs ----- libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: https://git.reviewboard.kde.org/r/105779/diff/ Testing ------- works for me Thanks, Greg T --===============2702261531340962691== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105779/

This change has been discarded.

Review request for Plasma.

By Greg T.

Updated Aug. 31, 2015, 11:02 a.m.

Bugs: 291422

Repository: kde-workspace

Description

QHash::values returns a list of items in arbitrary order. So I'm using a QMap to sort them by start time.

Testing

works for me

Diffs

libs/plasmaclock/calendartable.h (8678593)
libs/plasmaclock/calendartable.cpp (d2b436e)
libs/taskmanager/groupmanager.cpp (45c15a9)

View Diff

--===============2702261531340962691==-- --===============4583285740583885808== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4583285740583885808==--