'Re: Review Request 123686: Revert to old show desktop behaviour'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123686: Revert to old show desktop behaviour
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2015-08-31 10:53:21
Message-ID: 20150831105321.10622.14501 () mimi ! kde ! org
[Download RAW message or body]

--===============2700440428922843824==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123686/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 10:53 a.m.)

Status
------

This change has been discarded.

Review request for kwin, Plasma and KDE Usability.

Repository: kwin

Description
-------

Revert to old show desktop behaviour

This basically reverts the show desktop feature to the old behaviour.
Its meant as a temporary measure, since the new show desktop semantics
reveal a number of bugs and change the behaviour of the feature in a way
that makes it hard to go back to the original behaviour.

This feature will need more thinking, so rather bring back the old
behaviour in -stable to give us some time to hammer out the interaction
and bugs in the new implementation.

Diffs
-----

  client.h 40d503cfa917b7c116ab1b593c64dfb9f05513e4 
  client.cpp a6fbf3ea92ca713d6ad15aab30f6415663281ddf 
  layers.cpp b6d5b75f8f67a7d3f4d325acfe9e6e8c0da2b952 
  manage.cpp 75af4e519b929007fb3f36fe1ade71b89efb8a6a 
  workspace.h 4acefb4fc8c64e0abfae4b86222b869de193c6df 
  workspace.cpp 09ae9a2c113ba8c8ddfd0dd45ae91cdf20a78ba0 

Diff: https://git.reviewboard.kde.org/r/123686/diff/

Testing
-------

Used show desktop from panel, hot corner, checked if behaviour is consistent with \
previous behaviour.

Thanks,

Sebastian Kügler

--===============2700440428922843824==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123686/">https://git.reviewboard.kde.org/r/123686/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kwin, Plasma and KDE Usability.</div>
<div>By Sebastian Kügler.</div>

<p style="color: grey;"><i>Updated Aug. 31, 2015, 10:53 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Revert to old show desktop behaviour

This basically reverts the show desktop feature to the old behaviour.
Its meant as a temporary measure, since the new show desktop semantics
reveal a number of bugs and change the behaviour of the feature in a way
that makes it hard to go back to the original behaviour.

This feature will need more thinking, so rather bring back the old
behaviour in -stable to give us some time to hammer out the interaction
and bugs in the new implementation.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Used show desktop from panel, hot corner, checked if \
behaviour is consistent with previous behaviour.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>client.h <span style="color: \
grey">(40d503cfa917b7c116ab1b593c64dfb9f05513e4)</span></li>

 <li>client.cpp <span style="color: \
grey">(a6fbf3ea92ca713d6ad15aab30f6415663281ddf)</span></li>

 <li>layers.cpp <span style="color: \
grey">(b6d5b75f8f67a7d3f4d325acfe9e6e8c0da2b952)</span></li>

 <li>manage.cpp <span style="color: \
grey">(75af4e519b929007fb3f36fe1ade71b89efb8a6a)</span></li>

 <li>workspace.h <span style="color: \
grey">(4acefb4fc8c64e0abfae4b86222b869de193c6df)</span></li>

 <li>workspace.cpp <span style="color: \
grey">(09ae9a2c113ba8c8ddfd0dd45ae91cdf20a78ba0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123686/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2700440428922843824==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 