[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123828: Fix KF5 port regression in kcm_standard_actions
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-08-31 10:37:23
Message-ID: 20150831103723.10622.31595 () mimi ! kde ! org
[Download RAW message or body]
--===============0542967019318347766==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123828/#review84628
-----------------------------------------------------------
Ship it!
Hey, sorry this somehow got missed.
I'm not sure what happened, it seems everyone left it for everyone else... and \
there's clearly no-one looking at certain frameworks bugs properly.
Do you have commit access?
- David Edmundson
On July 12, 2015, 1:19 p.m., Simon Persson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123828/
> -----------------------------------------------------------
>
> (Updated July 12, 2015, 1:19 p.m.)
>
>
> Review request for Plasma, David Edmundson, Martin Gräßlin, and Michael Jansen.
>
>
> Bugs: 343665
> https://bugs.kde.org/show_bug.cgi?id=343665
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> The KShortcutsEditor reads the property "defaultShortcuts" from the assigned \
> QAction. Fill it in with default "hardcoded" shortcuts. Appending the defaults to \
> the list of active shortcuts just creates shortcut lists that grow longer and \
> longer every time user saves settings in this KCM.
> Still does not have a solution for upgrade of existing users' configuration. If the \
> user has a messed up "kdeglobals" file now, after installing upgrade with this fix \
> user will have to open up this KCM and hit "Defaults" button to reset settings. \
> After that things should work ok. I don't have any idea for solution of \
> automatically correcting broken config file after upgrade.
>
> Diffs
> -----
>
> kcms/standard_actions/standard_actions_module.cpp d1c4ad3
>
> Diff: https://git.reviewboard.kde.org/r/123828/diff/
>
>
> Testing
> -------
>
> Basic testing to see how the config file "kdeglobals" look after saving some \
> changed shortcuts, looks correct to me. Now only the shortcuts that are not default \
> are saved, and they are saved correctly (verified that by closing kcm, opening it \
> again and saw that my settings were still intact).
>
> Thanks,
>
> Simon Persson
>
>
--===============0542967019318347766==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123828/">https://git.reviewboard.kde.org/r/123828/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hey, \
sorry this somehow got missed. I'm not sure what happened, it seems everyone left it \
for everyone else... and there's clearly no-one looking at certain frameworks bugs \
properly.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Do you have commit access?</p></pre> <br />
<p>- David Edmundson</p>
<br />
<p>On July 12th, 2015, 1:19 p.m. UTC, Simon Persson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, David Edmundson, Martin Gräßlin, and Michael \
Jansen.</div> <div>By Simon Persson.</div>
<p style="color: grey;"><i>Updated July 12, 2015, 1:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=343665">343665</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The KShortcutsEditor reads the property \
"defaultShortcuts" from the assigned QAction. Fill it in with default "hardcoded" \
shortcuts. Appending the defaults to the list of active shortcuts just creates \
shortcut lists that grow longer and longer every time user saves settings in this \
KCM.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Still does not have a solution for upgrade of existing \
users' configuration. If the user has a messed up "kdeglobals" file now, after \
installing upgrade with this fix user will have to open up this KCM and hit \
"Defaults" button to reset settings. After that things should work ok. I don't have \
any idea for solution of automatically correcting broken config file after \
upgrade.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Basic testing to see how the config file "kdeglobals" \
look after saving some changed shortcuts, looks correct to me. Now only the shortcuts \
that are not default are saved, and they are saved correctly (verified that by \
closing kcm, opening it again and saw that my settings were still intact).</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/standard_actions/standard_actions_module.cpp <span style="color: \
grey">(d1c4ad3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123828/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0542967019318347766==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic