[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124929: [screenlocker] Cleanup in LockWindow
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-08-31 10:25:05
Message-ID: 20150831102505.10622.46858 () mimi ! kde ! org
[Download RAW message or body]
--===============6701323054570327541==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124929/#review84625
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Aug. 26, 2015, 5:55 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124929/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 5:55 a.m.)
>
>
> Review request for Plasma and David Edmundson.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> It set to arrow cursor which is the default anyway.
>
> [screenlocker] Drop setting event mask on the background window
>
> We don't need it as we get keyboard and pointer events anyway (grab),
> exposure is set by Qt anyway and for everything else we have
> substructure redirect on the root window.
>
> Setting the background pixel is also no longer needed: we render a
> black, non-translucent window.
>
> [screenlocker] Rename LockWindow to X11Locker
>
> The LockWindow is no longer a window, but it's the actual locker for
> X11.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/autotests/lockwindowtest.cpp \
> 7d8fe542b98ab19cf04554e179e63e238d34e09d ksmserver/screenlocker/ksldapp.h \
> 27c25df3bca7b30d78b1e4de34c437aa7ff33f59 ksmserver/screenlocker/ksldapp.cpp \
> 83527045890eac4e2cbd84767db10da4279cc5b5 ksmserver/screenlocker/lockwindow.h \
> dffaa729081cf3c6cff507f0a481e30666e2ddbc ksmserver/screenlocker/lockwindow.cpp \
> 41d54b3c5ffe67de4a09676e589effc4c564e470
> Diff: https://git.reviewboard.kde.org/r/124929/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============6701323054570327541==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124929/">https://git.reviewboard.kde.org/r/124929/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Edmundson</p>
<br />
<p>On August 26th, 2015, 5:55 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2015, 5:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It set to arrow cursor which is the default anyway.
[screenlocker] Drop setting event mask on the background window
We don't need it as we get keyboard and pointer events anyway (grab),
exposure is set by Qt anyway and for everything else we have
substructure redirect on the root window.
Setting the background pixel is also no longer needed: we render a
black, non-translucent window.
[screenlocker] Rename LockWindow to X11Locker
The LockWindow is no longer a window, but it's the actual locker for
X11.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/autotests/lockwindowtest.cpp <span style="color: \
grey">(7d8fe542b98ab19cf04554e179e63e238d34e09d)</span></li>
<li>ksmserver/screenlocker/ksldapp.h <span style="color: \
grey">(27c25df3bca7b30d78b1e4de34c437aa7ff33f59)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(83527045890eac4e2cbd84767db10da4279cc5b5)</span></li>
<li>ksmserver/screenlocker/lockwindow.h <span style="color: \
grey">(dffaa729081cf3c6cff507f0a481e30666e2ddbc)</span></li>
<li>ksmserver/screenlocker/lockwindow.cpp <span style="color: \
grey">(41d54b3c5ffe67de4a09676e589effc4c564e470)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124929/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6701323054570327541==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic