'Re: Review Request 124918: fix interface name'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124918: fix interface name
From:       "Harald Sitter" <sitter () kde ! org>
Date:       2015-08-31 8:11:18
Message-ID: 20150831081118.10622.11769 () mimi ! kde ! org
[Download RAW message or body]

--===============1593025410325072841==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124918/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 8:11 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Daniel Vrátil.

Changes
-------

Submitted with commit 3551aca3f1016d44e0b8d5a6d454859ba6a89773 by Harald Sitter to \
branch master.

Repository: kscreen

Description
-------

I am not quite confident how this worked (best guess is target order in
cmake). upower_interface.h is not used anywhere, what is used is
freedesktop_interface.h (in device.cpp) an consequently the build can
fail on this file not being found.

Switch the generated header to the actually used name to avoid build
failures from not being able to find it.

e.g. https://launchpadlibrarian.net/215492814/buildlog_ubuntu-wily-i386.kscreen_4%3A5.3.95%2Bgit20150825.0935%2B15.10-0_BUILDING.txt.gz
 the error happens and in another concurrent make job the interface is
built in the kded/ directory, so best guess is that this largely depends
on timing to go wrong.

Diffs
-----

  tests/kded/CMakeLists.txt e4b6bf5ec1383807826f312280f1fbea30fe388b 

Diff: https://git.reviewboard.kde.org/r/124918/diff/

Testing
-------

make (make test doesn't want to finish for some reason)

Thanks,

Harald Sitter

--===============1593025410325072841==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124918/">https://git.reviewboard.kde.org/r/124918/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Daniel Vrátil.</div>
<div>By Harald Sitter.</div>

<p style="color: grey;"><i>Updated Aug. 31, 2015, 8:11 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 3551aca3f1016d44e0b8d5a6d454859ba6a89773 by Harald \
Sitter to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kscreen
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I am not quite confident how this worked (best guess \
is target order in cmake). upower_interface.h is not used anywhere, what is used is
freedesktop_interface.h (in device.cpp) an consequently the build can
fail on this file not being found.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Switch the generated header to the actually used name \
to avoid build failures from not being able to find it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">e.g. \
https://launchpadlibrarian.net/215492814/buildlog_ubuntu-wily-i386.kscreen_4%3A5.3.95%2Bgit20150825.0935%2B15.10-0_BUILDING.txt.gz
 the error happens and in another concurrent make job the interface is
built in the kded/ directory, so best guess is that this largely depends
on timing to go wrong.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make (make test doesn't want to finish for some \
reason)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tests/kded/CMakeLists.txt <span style="color: \
grey">(e4b6bf5ec1383807826f312280f1fbea30fe388b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124918/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1593025410325072841==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 