'Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2015-08-31 6:25:51
Message-ID: 20150831062551.10622.29493 () mimi ! kde ! org
[Download RAW message or body]

--===============2104062259473704528==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124980/#review84618
-----------------------------------------------------------

components/sessionsprivate/sessionsmodel.h (line 56)
<https://git.reviewboard.kde.org/r/124980/#comment58553>

    suggestion: enum class, and then drop the Role from each name. Usage will be e.g. \
Roles::Icon

components/sessionsprivate/sessionsmodel.h (lines 73 - 75)
<https://git.reviewboard.kde.org/r/124980/#comment58556>

    add override

components/sessionsprivate/sessionsmodel.h (line 83)
<https://git.reviewboard.kde.org/r/124980/#comment58551>

    Is KDisplayManager using (blocking) DBus calls? If yes, I think we should design \
this to get it async.

components/sessionsprivate/sessionsmodel.h (line 85)
<https://git.reviewboard.kde.org/r/124980/#comment58552>

    Playing Milian: cetero censeo QList delendam esset.

    -> use QVector ;-)

components/sessionsprivate/sessionsmodel.cpp (lines 49 - 50)
<https://git.reviewboard.kde.org/r/124980/#comment58554>

    depending on how often it gets read I suggest to cache the value

components/sessionsprivate/sessionsmodel.cpp (line 73)
<https://git.reviewboard.kde.org/r/124980/#comment58558>

    The way to go is to emit the dbus call and connect to the signal for locked.

    so
    1. Connect globally to ksld's locked signal
    2. Track whether screen is locked initially
    3. if locked -> switch directly
    4. if not locked -> lock, wait for signal
    5. on signal: switch

components/sessionsprivate/sessionsmodel.cpp (line 80)
<https://git.reviewboard.kde.org/r/124980/#comment58555>

    either qCDebug or remove ;-)

components/sessionsprivate/sessionsmodel.cpp (line 111)
<https://git.reviewboard.kde.org/r/124980/#comment58557>

    same comment as for other debug statement

- Martin Gräßlin

On Aug. 29, 2015, 4:14 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124980/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2015, 4:14 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This way it can be used in the lock screen, user switcher, and a user switcher \
> plasmoid I'm planning. 
> Compared to the one in the lock screen it can also get the user's full name and \
> avatar, and some other information. 
> Perhaps we could also try to have it wait for the screen to actually lock before \
> switching sessions? 
> 
> Diffs
> -----
> 
> components/CMakeLists.txt 21fc61c 
> components/sessionsprivate/CMakeLists.txt PRE-CREATION 
> components/sessionsprivate/qmldir PRE-CREATION 
> components/sessionsprivate/sessionsmodel.h PRE-CREATION 
> components/sessionsprivate/sessionsmodel.cpp PRE-CREATION 
> components/sessionsprivate/sessionsprivateplugin.h PRE-CREATION 
> components/sessionsprivate/sessionsprivateplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124980/diff/
> 
> 
> Testing
> -------
> 
> Lists my sessions, allows to switch between them and start new ones. Locking when \
> creating a new session is missing. 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============2104062259473704528==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124980/">https://git.reviewboard.kde.org/r/124980/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/124980/diff/1/?file=399560#file399560line56" \
style="color: black; font-weight: bold; text-decoration: \
underline;">components/sessionsprivate/sessionsmodel.h</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">56</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">enum</span> <span class="n">Roles</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">suggestion: enum class, and then drop the Role from each name. Usage will \
be e.g. Roles::Icon</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/124980/diff/1/?file=399560#file399560line73" \
style="color: black; font-weight: bold; text-decoration: \
underline;">components/sessionsprivate/sessionsmodel.h</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">73</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QVariant</span> <span class="n">data</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QModelIndex</span> <span \
class="o">&amp;</span><span class="n">index</span><span class="p">,</span> <span \
class="kt">int</span> <span class="n">role</span> <span class="o">=</span> <span \
class="n">Qt</span><span class="o">::</span><span class="n">DisplayRole</span><span \
class="p">)</span> <span class="k">const</span><span class="p">;</span></pre></td>  \
</tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">74</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">int</span> <span class="n">rowCount</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QModelIndex</span> <span \
class="o">&amp;</span><span class="n">parent</span> <span class="o">=</span> <span \
class="n">QModelIndex</span><span class="p">())</span> <span \
class="k">const</span><span class="p">;</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">75</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QHash</span><span class="o">&lt;</span><span class="kt">int</span><span \
class="p">,</span> <span class="n">QByteArray</span><span class="o">&gt;</span> <span \
class="n">roleNames</span><span class="p">()</span> <span class="k">const</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">add \
override</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/124980/diff/1/?file=399560#file399560line83" \
style="color: black; font-weight: bold; text-decoration: \
underline;">components/sessionsprivate/sessionsmodel.h</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">83</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">KDisplayManager</span> <span class="n">m_displayManager</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is \
KDisplayManager using (blocking) DBus calls? If yes, I think we should design this to \
get it async.</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/124980/diff/1/?file=399560#file399560line85" \
style="color: black; font-weight: bold; text-decoration: \
underline;">components/sessionsprivate/sessionsmodel.h</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">85</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QList</span><span class="o">&lt;</span><span \
class="n">SessionEntry</span><span class="o">&gt;</span> <span \
class="n">m_data</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Playing Milian: cetero censeo QList delendam esset.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-&gt; \
use QVector ;-)</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/124980/diff/1/?file=399561#file399561line49" \
style="color: black; font-weight: bold; text-decoration: \
underline;">components/sessionsprivate/sessionsmodel.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">49</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">auto</span> <span class="n">config</span> <span class="o">=</span> <span \
class="n">KConfigGroup</span><span class="p">(</span><span \
class="n">KSharedConfig</span><span class="o">::</span><span \
class="n">openConfig</span><span class="p">(</span><span \
class="s">&quot;kscreenlockerrc&quot;</span><span class="p">),</span> <span \
class="s">&quot;Daemon&quot;</span><span class="p">);</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">return</span> <span class="n">KAuthorized</span><span \
class="o">::</span><span class="n">authorizeKAction</span><span \
class="p">(</span><span class="s">&quot;lock_screen&quot;</span><span \
class="p">)</span> <span class="o">&amp;&amp;</span> <span \
class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="s">&quot;Autolock&quot;</span><span class="p">,</span> \
<span class="nb">true</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">depending on how often it gets read I suggest to cache the value</p></pre>  \
</div> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/124980/diff/1/?file=399561#file399561line73" \
style="color: black; font-weight: bold; text-decoration: \
underline;">components/sessionsprivate/sessionsmodel.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">73</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="c1">// </span><span class="cs">TODO</span><span class="c1"> dbus call to lock \
screen</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
way to go is to emit the dbus call and connect to the signal for locked.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">so 1. Connect globally to ksld's locked signal
2. Track whether screen is locked initially
3. if locked -&gt; switch directly
4. if not locked -&gt; lock, wait for signal
5. on signal: switch</p></pre>
 </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/124980/diff/1/?file=399561#file399561line80" \
style="color: black; font-weight: bold; text-decoration: \
underline;">components/sessionsprivate/sessionsmodel.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">80</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">qDebug</span><span class="p">()</span> <span class="o">&lt;&lt;</span> \
<span class="s">&quot;INIT&quot;</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">either qCDebug or remove ;-)</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/124980/diff/1/?file=399561#file399561line111" \
style="color: black; font-weight: bold; text-decoration: \
underline;">components/sessionsprivate/sessionsmodel.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">111</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">qDebug</span><span class="p">()</span> <span class="o">&lt;&lt;</span> \
<span class="s">&quot;found&quot;</span> <span class="o">&lt;&lt;</span> <span \
class="n">entry</span><span class="p">.</span><span class="n">displayNumber</span> \
<span class="o">&lt;&lt;</span> <span class="n">entry</span><span \
class="p">.</span><span class="n">realName</span> <span class="o">&lt;&lt;</span> \
<span class="n">entry</span><span class="p">.</span><span class="n">name</span> <span \
class="o">&lt;&lt;</span> <span class="s">&quot;USER&quot;</span> <span \
class="o">&lt;&lt;</span> <span class="n">session</span><span class="p">.</span><span \
class="n">user</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">same \
comment as for other debug statement</p></pre>  </div>
</div>
<br />

<p>- Martin Gräßlin</p>

<br />
<p>On August 29th, 2015, 4:14 p.m. CEST, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Aug. 29, 2015, 4:14 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This way it can be used in the lock screen, user \
switcher, and a user switcher plasmoid I'm planning.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Compared to the one in the lock screen it can also get the user's full name \
and avatar, and some other information.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Perhaps we could also \
try to have it wait for the screen to actually lock before switching \
sessions?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Lists my sessions, allows to switch between them and \
start new ones. Locking when creating a new session is missing.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>components/CMakeLists.txt <span style="color: grey">(21fc61c)</span></li>

 <li>components/sessionsprivate/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>components/sessionsprivate/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>components/sessionsprivate/sessionsmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>components/sessionsprivate/sessionsmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>components/sessionsprivate/sessionsprivateplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>components/sessionsprivate/sessionsprivateplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124980/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2104062259473704528==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 