'Re: Review Request 124991: Fix autostart desktop file save location'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124991: Fix autostart desktop file save location
From:       "Laurent Montel" <montel () kde ! org>
Date:       2015-08-30 7:38:29
Message-ID: 20150830073829.11964.21002 () mimi ! kde ! org
[Download RAW message or body]

--===============5141747943156225253==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124991/#review84570
-----------------------------------------------------------

Sorry I didn't see this request.
I fixed it without it.
Again sorry about it.

- Laurent Montel

On août 30, 2015, 6:07 matin, Andrew Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124991/
> -----------------------------------------------------------
> 
> (Updated août 30, 2015, 6:07 matin)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 352005
> https://bugs.kde.org/show_bug.cgi?id=352005
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Commit 2bbda1e23fd8cff7350260e9003e489f9b838f39 left the traling slash in \
> m_desktopPath out, causing desktop files to be saved to autostart<program>.desktop \
> instead of autostart/<program>.desktop 
> 
> Diffs
> -----
> 
> kcms/autostart/autostart.cpp a45d524459ede920b45c5b1587049f77388c330a 
> 
> Diff: https://git.reviewboard.kde.org/r/124991/diff/
> 
> 
> Testing
> -------
> 
> Tested adding executables and applications.
> Tested disabling and enabling.
> 
> 
> Thanks,
> 
> Andrew Chen
> 
> 

--===============5141747943156225253==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124991/">https://git.reviewboard.kde.org/r/124991/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry \
I didn't see this request. I fixed it without it.
Again sorry about it.</p></pre>
 <br />

<p>- Laurent Montel</p>

<br />
<p>On août 30th, 2015, 6:07 matin UTC, Andrew Chen wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and David Edmundson.</div>
<div>By Andrew Chen.</div>

<p style="color: grey;"><i>Updated août 30, 2015, 6:07 matin</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=352005">352005</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Commit 2bbda1e23fd8cff7350260e9003e489f9b838f39 left \
the traling slash in m_desktopPath out, causing desktop files to be saved to \
autostart&lt;program&gt;.desktop instead of \
autostart/&lt;program&gt;.desktop</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested adding executables and applications. Tested \
disabling and enabling.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/autostart/autostart.cpp <span style="color: \
grey">(a45d524459ede920b45c5b1587049f77388c330a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124991/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5141747943156225253==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 