'Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-panel-devel
Subject: Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-08-29 14:33:09
Message-ID: 20150829143309.4103.489 () mimi ! kde ! org
[Download RAW message or body]

--===============1433695727943304871==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Aug. 28, 2015, 7:33 p.m., Martin Klapetek wrote:
> > CMakeLists.txt, line 38
> > <https://git.reviewboard.kde.org/r/124962/diff/1/?file=399442#file399442line38>
> > 
> > Shouldn't this be ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR} then?
> > 
> > Also, are pam modules actually supported outside of the default dir (I have no \
> > clue)?
> 
> Pinak Ahuja wrote:
> According to this: http://www.cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html \
> the syntax I've used is correct. I don't know if the pam modules are supported \
> outside the default dir either. My kdesrc build was failing because kwallet-pam was \
> not respecting the install prefix and installing the libs in /lib64 therefore I \
> investigated the problem.

> According to this: http://www.cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html \
> the syntax I've used is correct

Fwiw, that link only says that "${CMAKE_INSTALL_LIBDIR}" is a relative "lib/" path. \
The proper explanation is here: \
http://www.cmake.org/cmake/help/v3.0/command/install.html "If a relative path is \
given it is interpreted relative to the value of the CMAKE_INSTALL_PREFIX variable".

So that's good. But in other usages outside of install(), keep in mind that it gives \
you relative path only.

> My kdesrc build was failing because kwallet-pam was not respecting the install \
> prefix and installing the libs in /lib64

Well yes, because that's where PAM expects this module to be by default. So that's a \
whole wrong reason for this fix :P

But I've done the homework and it is actually possible to configure PAM with an \
absolute path in /etc/pam.d/stuff. So I guess this patch is fine, but I'd like to get \
some OKs from some distro people too.

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124962/#review84546
-----------------------------------------------------------

On Aug. 28, 2015, 9:39 a.m., Pinak Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124962/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 9:39 a.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: kwallet-pam
> 
> 
> Description
> -------
> 
> pam_kwallet5.so was being installed to /lib(64) irrespective of what the \
> installation prefix was set to. This patch fixes it. 
> 
> Diffs
> -----
> 
> CMakeLists.txt f60ac41 
> 
> Diff: https://git.reviewboard.kde.org/r/124962/diff/
> 
> 
> Testing
> -------
> 
> pam_kwallet5.so seems to install under the directory set as CMAKE_INSTALL_PREFIX
> 
> 
> Thanks,
> 
> Pinak Ahuja
> 
> 

--===============1433695727943304871==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124962/">https://git.reviewboard.kde.org/r/124962/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 28th, 2015, 7:33 p.m. CEST, <b>Martin \
Klapetek</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/124962/diff/1/?file=399442#file399442line38" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">38</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">install</span><span class="p">(</span><span class="s">TARGETS</span> <span \
class="o">${</span><span class="nv">library_name</span><span class="o">}</span> <span \
class="s">DESTINATION</span> <span class="s"><span class="hl">/</span></span><span \
class="o">${</span><span class="nv">CMAKE_INSTALL_LIBDIR</span><span \
class="o">}</span><span class="s">/security</span><span class="p">)</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">38</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">install</span><span class="p">(</span><span class="s">TARGETS</span> <span \
class="o">${</span><span class="nv">library_name</span><span class="o">}</span> <span \
class="s">DESTINATION</span> <span class="o">${</span><span \
class="nv">CMAKE_INSTALL_LIBDIR</span><span class="o">}</span><span \
class="s">/security</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Shouldn't this be ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR} then?</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also, are pam modules actually supported outside of \
the default dir (I have no clue)?</p></pre>  </blockquote>

 <p>On August 29th, 2015, 9:50 a.m. CEST, <b>Pinak Ahuja</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">According to this: \
http://www.cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html the syntax I've used \
is correct. I don't know if the pam modules are supported outside the default dir \
either. My kdesrc build was failing because kwallet-pam was not respecting the \
install prefix and installing the libs in /lib64 therefore I investigated the \
problem.</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> According to this: \
http://www.cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html the syntax I've used \
is correct </blockquote>
Fwiw, that link only says that \
"${CMAKE_INSTALL_LIBDIR}" is a relative "lib/" path. The proper explanation is here: \
http://www.cmake.org/cmake/help/v3.0/command/install.html "If a relative path is \
given it is interpreted relative to the value of the CMAKE_INSTALL_PREFIX \
variable". So that's good. But in other usages outside of \
install(), keep in mind that it gives you relative path only. <blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> My kdesrc build was failing because kwallet-pam was not respecting the \
install prefix and installing the libs in /lib64 </blockquote>
Well yes, because that's where PAM expects this module \
to be by default. So that's a whole wrong reason for this fix :P But I've done the homework and it is actually possible to configure PAM \
with an absolute path in /etc/pam.d/stuff. So I guess this patch is fine, but I'd \
like to get some OKs from some distro people too.</pre>

<p>- Martin</p>

<br />
<p>On August 28th, 2015, 9:39 a.m. CEST, Pinak Ahuja wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Martin Klapetek.</div>
<div>By Pinak Ahuja.</div>

<p style="color: grey;"><i>Updated Aug. 28, 2015, 9:39 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet-pam
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">pam_kwallet5.so was being installed to /lib(64) \
irrespective of what the installation prefix was set to. This patch fixes \
it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">pam_kwallet5.so seems to install under the directory \
set as CMAKE_INSTALL_PREFIX</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(f60ac41)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124962/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1433695727943304871==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 