[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124966: [screenlocker] Filter out XCB_FOCUS_OUT events in the screenlocker
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-08-28 12:07:01
Message-ID: 20150828120701.4103.53397 () mimi ! kde ! org
[Download RAW message or body]
--===============3129527425743824789==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 28, 2015, 1:25 p.m., David Edmundson wrote:
> > ksmserver/screenlocker/greeter/greeterapp.cpp, line 83
> > <https://git.reviewboard.kde.org/r/124966/diff/1/?file=399467#file399467line83>
> >
> > if (XCB_EVENT_RESPONSE_TYPE(event->response_type) == XCB_FOCUS_OUT)
>
> Martin Gräßlin wrote:
> what is that XCB_EVENT_RESPONSE_TYPE?
>
> David Edmundson wrote:
> a macro that does ( & 0x7f)
>
> so the same as what you've written, but without needing weird magic numbers.
>
> Martin Gräßlin wrote:
> and where does it come from? I just added it to the source, but it results in a \
> nice compile error.
> David Edmundson wrote:
> #include <xcb/xcb_event.h>
that would introduce a new dependency XCB::Util which we do not yet use in \
plasma-workspace. And there was a reason why I didn't use that in the past anywhere \
(I just don't remember why).
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124966/#review84530
-----------------------------------------------------------
On Aug. 28, 2015, 1:17 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124966/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2015, 1:17 p.m.)
>
>
> Review request for Plasma and Kåre Särs.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> The screenlocker has always focus, the backend is sending it events.
> So let's not allow X to tell Qt it doesn't have focus.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/greeterapp.cpp \
> b500ba44c2b483d7372ca46840152c90ef5f798c
> Diff: https://git.reviewboard.kde.org/r/124966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============3129527425743824789==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124966/">https://git.reviewboard.kde.org/r/124966/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 28th, 2015, 1:25 p.m. CEST, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124966/diff/1/?file=399467#file399467line83" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/screenlocker/greeter/greeterapp.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">83</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">((</span><span class="n">event</span><span \
class="o">-></span><span class="n">response_type</span> <span \
class="o">&</span> <span class="o">~</span><span class="mh">0x80</span><span \
class="p">)</span> <span class="o">==</span> <span \
class="n">XCB_FOCUS_OUT</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if \
(XCB_EVENT_RESPONSE_TYPE(event->response_type) == XCB_FOCUS_OUT)</p></pre> \
</blockquote>
<p>On August 28th, 2015, 1:31 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what \
is that XCB_EVENT_RESPONSE_TYPE?</p></pre> </blockquote>
<p>On August 28th, 2015, 1:39 p.m. CEST, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">a \
macro that does ( & 0x7f) </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">so the same as what \
you've written, but without needing weird magic numbers.</p></pre> </blockquote>
<p>On August 28th, 2015, 1:41 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and \
where does it come from? I just added it to the source, but it results in a nice \
compile error.</p></pre> </blockquote>
<p>On August 28th, 2015, 1:43 p.m. CEST, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><h1 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">include <xcb/xcb_event.h></h1></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">that would introduce a new dependency XCB::Util which we do not yet use in \
plasma-workspace. And there was a reason why I didn't use that in the past anywhere \
(I just don't remember why).</p></pre> <br />
<p>- Martin</p>
<br />
<p>On August 28th, 2015, 1:17 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Kåre Särs.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2015, 1:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The screenlocker has always focus, the backend is sending it events. So \
let's not allow X to tell Qt it doesn't have focus.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(b500ba44c2b483d7372ca46840152c90ef5f798c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124966/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3129527425743824789==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic